Skip to content

ACPI / EC: Fix EC event handling issues

Lv Zheng linux-acpi lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 1 replyIn review
  2. v34 patches 2 repliesApplied
  3. v24 patches 0 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ACPI / EC: Cleanup EC GPE mask flagdrivers/acpi/ec.c+11 -128 replies
1/3ACPI / EC: Fix possible driver order issue by moving EC event handling earlierdrivers/acpi/ec.c+19 -40 replies
2/3ACPI: EC: Add IRQ polling support for noirq stagesdrivers/acpi/ec.c drivers/acpi/internal.h+136 -00 replies
2/3ACPI / EC: Add event detection support for noirq stagesdrivers/acpi/ec.c drivers/acpi/internal.h+92 -20 replies
3/3ACPI: EC: Enable noirq stage GPE pollingdrivers/acpi/ec.c+1 -10 replies
3/3ACPI / EC: Enable noirq stage event detectiondrivers/acpi/ec.c+1 -10 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by.

PatchTomislav IvekLuya Tshimbalanga
1/3T-b T-b T-b T-b T-b T-b T-b T-b T-b
1/3T-b T-b T-b T-b T-b T-b T-b T-b T-b
2/3T-b
2/3T-b
3/3T-b
3/3T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/3] ACPI / EC: Fix EC event handling issues

EC events are special, required to be handled during suspend/resume. But there are special logics in Linux causing several issues related to the EC event handling:
1. During noirq stage, Linux cannot detect EC events which are target driven.
2. When EC event handling is enabled later than the other drivers, order problem could be observed.
When fixing these problems, care should be taken to not to trigger regressions to the following problem which has alredy been fixed using different approach):
3. When EC event handling is enabled before the end of the noirq stage, EC event handling may stuck.
This patchset fixes these issues.

v4 of this patch series re-orders the fixes so that the fix of the problem 2 could be independent against the fix of the problem 1, this is done by refining the fix of the problem 2, making it immune to the problem 3.

Lv Zheng (3):
ACPI / EC: Fix possible driver order issue by moving EC event handling
earlier
ACPI / EC: Add event detection support for noirq stages ACPI / EC: Enable noirq stage event detection

 drivers/acpi/ec.c       | 116 +++++++++++++++++++++++++++++++++++++++++++++---
 drivers/acpi/internal.h |   1 +
 2 files changed, 111 insertions(+), 6 deletions(-)
Signature · 1 line
2.7.4