Skip to content

sctp: remove typedefs from structures part 4

Xin Long linux-sctp netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14sctp: remove the typedef sctp_shutdownhdr_tinclude/linux/sctp.h net/sctp/sm_make_chunk.c net/sctp/sm_statefuns.c+10 -100 replies
2/14sctp: fix the name of struct sctp_shutdown_chunk_tinclude/linux/sctp.h net/sctp/sm_statefuns.c+9 -90 replies
3/14sctp: remove the typedef sctp_errhdr_tinclude/linux/sctp.h include/net/sctp/sctp.h net/sctp/sm_make_chunk.c +3 more+48 -450 replies
4/14sctp: remove the typedef sctp_operr_chunk_tinclude/linux/sctp.h net/sctp/sm_statefuns.c+4 -40 replies
5/14sctp: remove the typedef sctp_error_tinclude/linux/sctp.h net/sctp/sm_statefuns.c+3 -30 replies
6/14sctp: remove the typedef sctp_ecnehdr_tinclude/linux/sctp.h net/sctp/sm_make_chunk.c net/sctp/sm_statefuns.c+8 -80 replies
7/14sctp: remove the typedef sctp_ecne_chunk_tinclude/linux/sctp.h net/sctp/sm_statefuns.c+4 -40 replies
8/14sctp: remove the typedef sctp_cwrhdr_tinclude/linux/sctp.h net/sctp/sm_make_chunk.c net/sctp/sm_statefuns.c+8 -80 replies
9/14sctp: remove the typedef sctp_cwr_chunk_tinclude/linux/sctp.h+0 -50 replies
10/14sctp: remove the typedef sctp_addip_param_tinclude/linux/sctp.h net/sctp/sm_make_chunk.c+24 -230 replies
11/14sctp: remove the typedef sctp_addiphdr_tinclude/linux/sctp.h net/sctp/sm_make_chunk.c net/sctp/sm_statefuns.c+15 -150 replies
12/14sctp: remove the typedef sctp_addip_chunk_tinclude/linux/sctp.h net/sctp/input.c net/sctp/sm_make_chunk.c +1 more+15 -100 replies
13/14sctp: remove the typedef sctp_authhdr_tinclude/linux/sctp.h net/sctp/sm_make_chunk.c+7 -70 replies
14/14sctp: remove the typedef sctp_auth_chunk_tinclude/linux/sctp.h net/sctp/chunk.c net/sctp/sm_statefuns.c+8 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 00/14] sctp: remove typedefs from structures part 4

As we know, typedef is suggested not to use in kernel, even checkpatch.pl also gives warnings about it. Now sctp is using it for many structures.

All this kind of typedef's using should be removed. This patchset is the part 4 to remove it for another 14 basic structures from linux/sctp.h. After this patchset, all typedefs are cleaned in linux/sctp.h.

Just as the part 1-3, No any code's logic would be changed in these patches, only cleaning up.

Xin Long (14):
sctp: remove the typedef sctp_shutdownhdr_t
sctp: fix the name of struct sctp_shutdown_chunk_t
sctp: remove the typedef sctp_errhdr_t
sctp: remove the typedef sctp_operr_chunk_t
sctp: remove the typedef sctp_error_t
sctp: remove the typedef sctp_ecnehdr_t
sctp: remove the typedef sctp_ecne_chunk_t
sctp: remove the typedef sctp_cwrhdr_t
sctp: remove the typedef sctp_cwr_chunk_t
sctp: remove the typedef sctp_addip_param_t
sctp: remove the typedef sctp_addiphdr_t
sctp: remove the typedef sctp_addip_chunk_t
sctp: remove the typedef sctp_authhdr_t
sctp: remove the typedef sctp_auth_chunk_t

 include/linux/sctp.h     |  69 +++++++++++++--------------
 include/net/sctp/sctp.h  |   8 ++--
 net/sctp/chunk.c         |   2 +-
 net/sctp/input.c         |   2 +-
 net/sctp/sm_make_chunk.c | 119 ++++++++++++++++++++++++-----------------------
 net/sctp/sm_sideeffect.c |   2 +-
 net/sctp/sm_statefuns.c  | 107 ++++++++++++++++++++++--------------------
 net/sctp/ulpevent.c      |  10 ++--
 8 files changed, 162 insertions(+), 157 deletions(-)
Signature · 1 line
2.1.0