Skip to content

esp_scsi, mac_esp: Various fixes and cleanups

Finn Thain linux-scsi lkml 1 version Applied

Status from this message: Applied to 4.14/scsi-queue. Thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/5scsi/mac_esp: Avoid type warning from sparsedrivers/scsi/mac_esp.c+1 -10 replies
2/5scsi/mac_esp: Fix PIO transfers for MESSAGE IN phasedrivers/scsi/mac_esp.c+18 -170 replies
3/5scsi/esp_scsi: Clean up control flow and dead codedrivers/scsi/esp_scsi.c drivers/scsi/esp_scsi.h+14 -270 replies
4/5scsi/esp_scsi: Avoid sending ABORT TASK SET messagesdrivers/scsi/esp_scsi.c+7 -40 replies
5/5scsi/esp_scsi: Always clear msg_out_len after MESSAGE OUT phasedrivers/scsi/esp_scsi.c+2 -00 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by.

PatchStan Johnson
1/5T-b
2/5T-b
3/5T-b
4/5T-b
5/5T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] esp_scsi, mac_esp: Various fixes and cleanups

This series has been tested on m68k Macs (ESP236 equivalent).

Some more testing with different targets and devices (FAS236 etc) might be nice. Being that the esp_scsi fixes are on error paths, more review may actually be more valuable than more testing...

Finn Thain (5):
scsi/mac_esp: Avoid type warning from sparse scsi/mac_esp: Fix PIO transfers for MESSAGE IN phase scsi/esp_scsi: Clean up control flow and dead code scsi/esp_scsi: Avoid sending ABORT TASK SET messages scsi/esp_scsi: Always clear msg_out_len after MESSAGE OUT phase

 drivers/scsi/esp_scsi.c | 53 +++++++++++++++++++++----------------------------
 drivers/scsi/esp_scsi.h |  1 -
 drivers/scsi/mac_esp.c  | 37 +++++++++++++++++-----------------
 3 files changed, 42 insertions(+), 49 deletions(-)
Signature · 1 line
2.13.0