Skip to content

sctp: remove typedefs from structures part 5

Xin Long linux-sctp netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14sctp: remove the typedef sctp_lower_cwnd_tinclude/net/sctp/constants.h include/net/sctp/structs.h net/sctp/transport.c+5 -40 replies
2/14sctp: remove the typedef sctp_retransmit_reason_tinclude/net/sctp/constants.h include/net/sctp/structs.h net/sctp/outqueue.c+5 -50 replies
3/14sctp: remove the typedef sctp_scope_policy_tinclude/net/sctp/constants.h net/sctp/sysctl.c+5 -32 replies
4/14sctp: remove the typedef sctp_scope_tinclude/net/sctp/constants.h include/net/sctp/sctp.h include/net/sctp/structs.h +6 more+42 -420 replies
5/14sctp: remove the typedef sctp_transport_cmd_tinclude/net/sctp/constants.h include/net/sctp/structs.h net/sctp/associola.c+7 -60 replies
6/14sctp: remove the typedef sctp_sock_state_tinclude/net/sctp/constants.h include/net/sctp/sctp.h+5 -40 replies
7/14sctp: remove the typedef sctp_xmit_tinclude/net/sctp/constants.h include/net/sctp/structs.h net/sctp/output.c +1 more+41 -400 replies
8/14sctp: remove the typedef sctp_ierror_tinclude/net/sctp/constants.h net/sctp/sm_make_chunk.c net/sctp/sm_statefuns.c+29 -270 replies
9/14sctp: remove the typedef sctp_state_tinclude/net/sctp/command.h include/net/sctp/constants.h include/net/sctp/sctp.h +6 more+28 -260 replies
10/14sctp: remove the typedef sctp_event_primitive_tinclude/net/sctp/constants.h+4 -40 replies
11/14sctp: remove the typedef sctp_event_other_tinclude/net/sctp/constants.h+4 -40 replies
12/14sctp: remove the typedef sctp_event_timeout_tinclude/net/sctp/command.h include/net/sctp/constants.h net/sctp/sm_sideeffect.c+9 -90 replies
13/14sctp: remove the typedef sctp_event_tinclude/net/sctp/constants.h include/net/sctp/sm.h net/sctp/primitive.c +2 more+18 -240 replies
14/14sctp: remove the typedef sctp_subtype_tinclude/net/sctp/constants.h include/net/sctp/sm.h net/sctp/associola.c +7 more+134 -1290 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 00/14] sctp: remove typedefs from structures part 5

As we know, typedef is suggested not to use in kernel, even checkpatch.pl also gives warnings about it. Now sctp is using it for many structures.

All this kind of typedef's using should be removed. This patchset is the part 5 to remove all typedefs in include/net/sctp/constants.h.

Just as the part 1-4, No any code's logic would be changed in these patches, only cleaning up.

Xin Long (14):
sctp: remove the typedef sctp_lower_cwnd_t
sctp: remove the typedef sctp_retransmit_reason_t
sctp: remove the typedef sctp_scope_policy_t
sctp: remove the typedef sctp_scope_t
sctp: remove the typedef sctp_transport_cmd_t
sctp: remove the typedef sctp_sock_state_t
sctp: remove the typedef sctp_xmit_t
sctp: remove the typedef sctp_ierror_t
sctp: remove the typedef sctp_state_t
sctp: remove the typedef sctp_event_primitive_t
sctp: remove the typedef sctp_event_other_t
sctp: remove the typedef sctp_event_timeout_t
sctp: remove the typedef sctp_event_t
sctp: remove the typedef sctp_subtype_t

 include/net/sctp/command.h   |   8 +-
 include/net/sctp/constants.h |  89 +++++++++---------
 include/net/sctp/sctp.h      |   9 +-
 include/net/sctp/sm.h        |  21 ++---
 include/net/sctp/structs.h   |  42 +++++----
 net/sctp/associola.c         |  21 ++---
 net/sctp/bind_addr.c         |  20 ++--
 net/sctp/debug.c             |   8 +-
 net/sctp/endpointola.c       |   4 +-
 net/sctp/ipv6.c              |   6 +-
 net/sctp/output.c            |  60 ++++++------
 net/sctp/outqueue.c          |  10 +-
 net/sctp/primitive.c         |   4 +-
 net/sctp/probe.c             |   2 +-
 net/sctp/protocol.c          |   6 +-
 net/sctp/sm_make_chunk.c     |  29 +++---
 net/sctp/sm_sideeffect.c     |  46 ++++-----
 net/sctp/sm_statefuns.c      | 215 ++++++++++++++++++++++---------------------
 net/sctp/sm_statetable.c     |  23 +++--
 net/sctp/socket.c            |   4 +-
 net/sctp/sysctl.c            |   2 +-
 net/sctp/transport.c         |   2 +-
 22 files changed, 320 insertions(+), 311 deletions(-)
Signature · 1 line
2.1.0