Skip to content

VHDX bugfixes

Jeff Cody qemu-devel 2 versions Applied

Status from this message: Thanks, applied to the block branch.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 4 repliesApplied
  2. v12 patches 7 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/4block/vhdx: check error return of bdrv_getlength()block/vhdx-log.c block/vhdx.c+26 -60 replies
2/4block/vhdx: check for offset overflow to bdrv_truncate()block/vhdx-log.c block/vhdx.c+8 -11 reply
3/4block/vhdx: check error return of bdrv_flush()block/vhdx-log.c+14 -31 reply
4/4block/vhdx: check error return of bdrv_truncate()block/vhdx-log.c+5 -11 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchEric BlakeKevin WolfPhilippe Mathieu-Daudé
1/4R-b
2/4R-b R-b R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 for-2.10 0/4] VHDX bugfixes

Some VHDX bug fixes, including:

1. Checking bdrv_getlength(), bdrv_flush(), and bdrv_truncate() return values

Changes from v1->v2:

git-backport-diff -r qemu/master.. -u vhdx-fixes-v1
Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/4:[0013] [FC] 'block/vhdx: check error return of bdrv_getlength()'

       ^^^^

Some code cleanup / movement (Thanks Kevin)

002/4:[0002] [FC] 'block/vhdx: check for offset overflow to bdrv_truncate()'

       ^^^^

Use QEMU_ALIGN_UP (Thanks Eric)

003/4:[down] 'block/vhdx: check error return of bdrv_flush()'

New, suggested by Kevin.

004/4:[down] 'block/vhdx: check error return of bdrv_truncate()'

New.

1. Check for error when calling bdrv_getlength() [Markus]

2. Check for overflow in offset prior to calling bdrv_truncate().

Jeff Cody (4):
block/vhdx: check error return of bdrv_getlength() block/vhdx: check for offset overflow to bdrv_truncate() block/vhdx: check error return of bdrv_flush() block/vhdx: check error return of bdrv_truncate()

 block/vhdx-log.c | 52 ++++++++++++++++++++++++++++++++++++++++++----------
 block/vhdx.c     | 12 +++++++++++-
 2 files changed, 53 insertions(+), 11 deletions(-)
Signature · 1 line
2.9.4