bsg: fix regression resulting in panics when sending commands via BSG
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest1 patch 3 repliesIn review
- v1 RFC6 patches 24 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | bsg-lib: fix kernel panic resulting from missing allocation of reply-bufferblock/ include/ include/ | +46 | 2 replies |
Reviews trailers per patch
The patch has a Reviewed-by or Acked-by.
| Patch | Christoph Hellwig |
|---|---|
| 1/1 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/1] bsg: fix regression resulting in panics when sending commands via BSG
Hello all,
This is the second try for fixing the regression in the BSG-interface that exists since v4.11 (for more infos see the first series).
I separated my other changes from the bug-fix so that it is easier to apply if judged good. I will rebase my cleanups I sent in v1 and send them when I get a bit more time. But the regression-fix is more important, so here's that.
I did some more tests on it than on v1, including some heavy parallel I/O on the same blk-queue using both BSG and the normal SCSI-stack at the same time (throwing some intentional bad commands in it too). That seemed to work all well enough - i.e. it didn't crash and got the expected results. I haven't done any external error-inject, but IMO that would be beyond the scope right now.
The fix is based on Christoph's idea, I discussed this with him off-list already.
I rebased the series on Jens' for-next.
Reviews are more than welcome :)
Beste Grüße / Best regards,
- Benjamin Block
Benjamin Block (1):
bsg-lib: fix kernel panic resulting from missing allocation of
reply-buffer
block/bsg-lib.c | 74 +++++++++++++++++++++++++++++-------------------- include/linux/blkdev.h | 1 - include/linux/bsg-lib.h | 2 ++ 3 files changed, 46 insertions(+), 31 deletions(-)
Signature · 4 lines
Linux on z Systems Development / IBM Systems & Technology Group
IBM Deutschland Research & Development GmbH
Vorsitz. AufsR.: Martina Koederitz / Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen / Registergericht: AmtsG Stuttgart, HRB 243294