clean up parsing of maybe_bool
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 patches 6 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | Doc/git-{push,send-pack}: correct --sign= to --signed=Documentation/ Documentation/ | +4 | 0 replies | |
| 2/6 | t5334: document that git push --signed=1 does not workt/ | +7 | 1 reply | |
| 3/6 | config: introduce git_parse_maybe_bool_textconfig.c | +8 | 0 replies | |
| 4/6 | config: make git_{config,parse}_maybe_bool equivalentconfig.c t/ | +6 | 0 replies | |
| 5/6 | treewide: deprecate git_config_maybe_bool, use git_parse_maybe_boolDocumentation/ builtin/ builtin/ +7 more | +18 | 0 replies | |
| 6/6 | parse_decoration_style: drop unused argument `var`builtin/ | +3 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/6] clean up parsing of maybe_bool
When we want to parse a boolean config item without dying on error, we call git_config_maybe_bool() which takes two arguments: the value to be parsed (obviously) and a name which is completely ignored. Junio has suggested to drop name and rename the function [1]. That effort even started shortly after that, by introducing git_parse_maybe_bool(). The new function currently only has a single user outside config.c.
Patch 5 of this series deprecates the old function and updates all callers to use git_parse_maybe_bool() instead. Patch 6 is a final
cleanup: one of the converted callers suddenly had an unused argument.
Patches 3 and 4 prepare for the switch. In particular, patch 4 ensures that the two functions are actually equivalent. In doing so, it affects git push --signed=.. which was very slightly inconsistent to the rest of Git.
Patch 2 adds a failing test in preparation for patch 4. Patch 1 corrects the documentation not to say "git push --sign=.." to make it a bit more obvious that the opposite typo is not being made in patches 2 and 4.
git_parse_maybe_bool is used in sb/diff-color-move, which is in "next". This series makes --color-moved and diff.colormoved consistent with other booleans. That should be a good thing, but cc Stefan to be sure.
Martin
[1] https://public-inbox.org/git/[email protected]/
Martin Ågren (6):
Doc/git-{push,send-pack}: correct --sign= to --signed=
t5334: document that git push --signed=1 does not work
config: introduce git_parse_maybe_bool_text
config: make git_{config,parse}_maybe_bool equivalent
treewide: deprecate git_config_maybe_bool, use git_parse_maybe_bool
parse_decoration_style: drop unused argument var
Documentation/git-push.txt | 4 ++-- Documentation/git-send-pack.txt | 4 ++-- Documentation/technical/api-config.txt | 4 ++++ t/t5534-push-signed.sh | 7 +++++++ builtin/log.c | 10 +++++----- builtin/merge.c | 4 ++-- builtin/pull.c | 4 ++-- builtin/push.c | 2 +- builtin/remote.c | 2 +- builtin/send-pack.c | 2 +- config.c | 15 ++++++++++----- pager.c | 2 +- submodule-config.c | 6 +++--- 13 files changed, 41 insertions(+), 25 deletions(-)
Signature · 1 line
2.14.0.5.g0f7b1ed27