Skip to content

Code cleanup and minor fixes (for 2.11)

Jeff Cody qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 18 repliesIn review
  2. v27 patches 11 repliesSuperseded
  3. v17 patches 0 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7block/ssh: don't call libssh2_init() in block_init()block/ssh.c+26 -112 replies
2/7block/ssh: make compliant with coding guidelinesblock/ssh.c+18 -142 replies
3/7block/sheepdog: remove spurious NULL checkblock/sheepdog.c+1 -11 reply
4/7block/sheepdog: code beautificationblock/sheepdog.c+82 -821 reply
5/7block/curl: check error return of curl_global_init()block/curl.c+12 -62 replies
6/7block/curl: fix minor memory leaksblock/curl.c+6 -03 replies
7/7block/curl: code cleanup to comply with coding styleblock/curl.c+52 -486 replies

Reviews trailers per patch

6 of 7 patches have a Reviewed-by or Acked-by.

PatchEric BlakePhilippe Mathieu-DaudéDarren KennyRichard W.M. Jones
1/7
2/7R-b R-b R-b
3/7R-b R-b
4/7R-b R-b
5/7R-b R-b R-b
6/7R-b R-b R-b
7/7R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/7] Code cleanup and minor fixes (for 2.11)

Changes from v2 -> v3:

Patch 1: Return -EIO for ssh_state_init() (Thanks Eric) Patch 4: fixed missed line (Thanks Eric)
Patch 7: fixed opaque pointer assignment (Thanks Eric)

git-backport-diff -r master.. -u 81fb084

001/7:[0007] [FC] 'block/ssh: don't call libssh2_init() in block_init()' 002/7:[----] [--] 'block/ssh: make compliant with coding guidelines' 003/7:[----] [--] 'block/sheepdog: remove spurious NULL check' 004/7:[0010] [FC] 'block/sheepdog: code beautification' 005/7:[----] [--] 'block/curl: check error return of curl_global_init()' 006/7:[----] [--] 'block/curl: fix minor memory leaks' 007/7:[0002] [FC] 'block/curl: code cleanup to comply with coding style'

Jeff Cody (7):
block/ssh: don't call libssh2_init() in block_init() block/ssh: make compliant with coding guidelines block/sheepdog: remove spurious NULL check block/sheepdog: code beautification block/curl: check error return of curl_global_init() block/curl: fix minor memory leaks block/curl: code cleanup to comply with coding style

 block/curl.c     | 124 +++++++++++++++++++++++------------------
 block/sheepdog.c | 166 +++++++++++++++++++++++++++----------------------------
 block/ssh.c      |  69 ++++++++++++++---------
 3 files changed, 197 insertions(+), 162 deletions(-)
Signature · 1 line
2.9.5