Skip to content

sctp: remove typedefs from structures part 6

Xin Long linux-sctp netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14sctp: remove the unused typedef sctp_packet_phandler_tinclude/net/sctp/structs.h+0 -20 replies
2/14sctp: remove the typedef sctp_sender_hb_info_tinclude/net/sctp/structs.h net/sctp/sm_make_chunk.c net/sctp/sm_sideeffect.c +1 more+12 -140 replies
3/14sctp: remove the typedef sctp_endpoint_type_tinclude/net/sctp/structs.h+3 -30 replies
4/14sctp: remove the typedef sctp_cmsgs_tinclude/net/sctp/structs.h net/sctp/socket.c+7 -60 replies
5/14sctp: remove the typedef sctp_dbg_objcnt_entry_tinclude/net/sctp/structs.h net/sctp/objcnt.c+3 -30 replies
6/14sctp: remove the typedef sctp_socket_type_tinclude/net/sctp/sctp.h include/net/sctp/structs.h net/sctp/socket.c+9 -70 replies
7/14sctp: remove the typedef sctp_cmd_tinclude/net/sctp/command.h net/sctp/sm_sideeffect.c+8 -80 replies
8/14sctp: remove the typedef sctp_cmd_seq_tinclude/net/sctp/command.h include/net/sctp/sm.h net/sctp/probe.c +2 more+145 -1430 replies
9/14sctp: remove the typedef sctp_arg_tinclude/net/sctp/command.h net/sctp/sm_statefuns.c+14 -140 replies
10/14sctp: remove the typedef sctp_verb_tinclude/net/sctp/command.h net/sctp/sm_statefuns.c+6 -60 replies
11/14sctp: remove the unused typedef sctp_sm_command_tinclude/net/sctp/sm.h+0 -50 replies
12/14sctp: remove the typedef sctp_sm_table_entry_tinclude/net/sctp/sm.h net/sctp/sm_sideeffect.c net/sctp/sm_statetable.c+29 -210 replies
13/14sctp: remove the typedef sctp_disposition_tinclude/net/sctp/sm.h net/sctp/probe.c net/sctp/sm_sideeffect.c +1 more+717 -6810 replies
14/14sctp: fix some indents in sm_make_chunk.cinclude/net/sctp/sm.h net/sctp/sm_make_chunk.c+249 -2570 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 00/14] sctp: remove typedefs from structures part 6

As we know, typedef is suggested not to use in kernel, even checkpatch.pl also gives warnings about it. Now sctp is using it for many structures.

All this kind of typedef's using should be removed. This patchset is the part 6 to remove all typedefs in include/net/sctp/structs.h, command.h and sm.h.

Just as the part 1-5, No any code's logic would be changed in these patches, only cleaning up.

Note that this is the last part for this typedef cleaning up. after this patchset, no more inappropriate typedefs in sctp. It's also to tidy some codes when removing them, like fixing many indents, reodering some local params, especially in the last 2 patches.

Xin Long (14):
sctp: remove the unused typedef sctp_packet_phandler_t
sctp: remove the typedef sctp_sender_hb_info_t
sctp: remove the typedef sctp_endpoint_type_t
sctp: remove the typedef sctp_cmsgs_t
sctp: remove the typedef sctp_dbg_objcnt_entry_t
sctp: remove the typedef sctp_socket_type_t
sctp: remove the typedef sctp_cmd_t
sctp: remove the typedef sctp_cmd_seq_t
sctp: remove the typedef sctp_arg_t
sctp: remove the typedef sctp_verb_t
sctp: remove the unused typedef sctp_sm_command_t
sctp: remove the typedef sctp_sm_table_entry_t
sctp: remove the typedef sctp_disposition_t
sctp: fix some indents in sm_make_chunk.c

 include/net/sctp/command.h |   58 +-
 include/net/sctp/sctp.h    |    3 +-
 include/net/sctp/sm.h      |  188 +++---
 include/net/sctp/structs.h |   26 +-
 net/sctp/objcnt.c          |    2 +-
 net/sctp/probe.c           |   13 +-
 net/sctp/sm_make_chunk.c   |  354 ++++++------
 net/sctp/sm_sideeffect.c   |  106 ++--
 net/sctp/sm_statefuns.c    | 1368 +++++++++++++++++++++++---------------------
 net/sctp/sm_statetable.c   |   42 +-
 net/sctp/socket.c          |   16 +-
 11 files changed, 1104 insertions(+), 1072 deletions(-)
Signature · 1 line
2.1.0