Skip to content

Misc throttle fixes

Alberto Garcia qemu-devel 2 versions – Applied

Status from this message: Thanks, applied to my block-next tree:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 5 repliesApplied
  2. v14 patches 6 repliesSuperseded

Changes in v2 from the cover letter

- Patch 3: Make the code a bit more concise
- Patch 5: LeakyBucket.avg and LeakyBucket.max are now unsigned
- Patch 6: Make burst_length 64bit and check its range
- Patch 7: Add unit tests

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/7throttle: Fix wrong variable name in the header documentationinclude/qemu/throttle.h+1 -10 replies
2/7throttle: Update the throttle_fix_bucket() documentationutil/throttle.c+3 -81 reply
3/7throttle: Make throttle_is_valid() a bit less verboseutil/throttle.c+7 -81 reply
4/7throttle: Remove throttle_fix_bucket() / throttle_unfix_bucket()util/throttle.c+23 -390 replies
5/7throttle: Make LeakyBucket.avg and LeakyBucket.max integer typesinclude/qemu/throttle.h tests/test-throttle.c util/throttle.c+7 -71 reply
6/7throttle: Make burst_length 64bit and add range checksinclude/qemu/throttle.h util/throttle.c+6 -11 reply
7/7throttle: Test the valid range of config valuestests/test-throttle.c+77 -00 replies

Reviews trailers per patch

6 of 7 patches have a Reviewed-by or Acked-by.

PatchManos PitsidianakisEric Blake
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/7] Misc throttle fixes

Hi,

here's the new version of my patch series with misc fixes for the throttling code.

Stefan, once this is reviewed, can you please remove the "Make LeakyBucket.avg and LeakyBucket.max integer types" commit (id 218f470639117a8e39) from your block-next branch? This series contains a new version of that patch that replaces the one that you have.

v2:
- Patch 3: Make the code a bit more concise
- Patch 5: LeakyBucket.avg and LeakyBucket.max are now unsigned
- Patch 6: Make burst_length 64bit and check its range
- Patch 7: Add unit tests

v1: https://lists.gnu.org/archive/html/qemu-block/2017-08/msg00753.html
- Initial version

Output of backport-diff against v1:

Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/7:[----] [--] 'throttle: Fix wrong variable name in the header documentation' 002/7:[----] [--] 'throttle: Update the throttle_fix_bucket() documentation' 003/7:[down] 'throttle: Make throttle_is_valid() a bit less verbose' 004/7:[----] [--] 'throttle: Remove throttle_fix_bucket() / throttle_unfix_bucket()' 005/7:[0010] [FC] 'throttle: Make LeakyBucket.avg and LeakyBucket.max integer types' 006/7:[down] 'throttle: Make burst_length 64bit and add range checks' 007/7:[down] 'throttle: Test the valid range of config values'

Alberto Garcia (7):
throttle: Fix wrong variable name in the header documentation
throttle: Update the throttle_fix_bucket() documentation
throttle: Make throttle_is_valid() a bit less verbose
throttle: Remove throttle_fix_bucket() / throttle_unfix_bucket()
throttle: Make LeakyBucket.avg and LeakyBucket.max integer types
throttle: Make burst_length 64bit and add range checks
throttle: Test the valid range of config values

 include/qemu/throttle.h |  8 ++---
 tests/test-throttle.c   | 80 ++++++++++++++++++++++++++++++++++++++++++++-
 util/throttle.c         | 86 +++++++++++++++++++------------------------------
 3 files changed, 117 insertions(+), 57 deletions(-)
Signature · 1 line
2.11.0

Read the cover letter in its thread