Skip to content

Convert hash-object to struct object_id

Patryk Obara git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6builtin/hash-object: convert to struct object_idbuiltin/hash-object.c+6 -60 replies
2/6read-cache: convert to struct object_idread-cache.c+3 -30 replies
3/6sha1_file: convert index_path to struct object_idbuiltin/update-index.c cache.h diff.c +3 more+10 -100 replies
4/6sha1_file: convert index_fd to struct object_idbuiltin/difftool.c builtin/hash-object.c builtin/replace.c +3 more+12 -120 replies
5/6sha1_file: convert hash_sha1_file_literally to struct object_idbuiltin/hash-object.c cache.h sha1_file.c+6 -61 reply
6/6sha1_file: convert index_stream to struct object_idsha1_file.c+3 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] Convert hash-object to struct object_id

This enabled conversion of few functions in sha1_file, which had almost all callers converted already.

I hope I'm not stepping on anyone's toes with this patch series. If I do - is there some email thread or document in which I can coordinate with other developers, regarding which code regions are being converted to struct object_id next?

I focused on this builtin in particular because it's probably the smallest functionality, that can be converted to different hashing algorithm, at least partly.

Patryk Obara (6):
builtin/hash-object: convert to struct object_id
read-cache: convert to struct object_id
sha1_file: convert index_path to struct object_id
sha1_file: convert index_fd to struct object_id
sha1_file: convert hash_sha1_file_literally to struct object_id
sha1_file: convert index_stream to struct object_id

 builtin/difftool.c     |  2 +-
 builtin/hash-object.c  | 12 ++++++------
 builtin/replace.c      |  2 +-
 builtin/update-index.c |  2 +-
 cache.h                |  6 +++---
 diff.c                 |  2 +-
 notes-merge.c          |  2 +-
 read-cache.c           |  8 ++++----
 sha1_file.c            | 34 +++++++++++++++++-----------------
 9 files changed, 35 insertions(+), 35 deletions(-)
Signature · 1 line
2.9.5