Skip to content

IIO driver for MCP3550/1/3

Lukas Wunner linux-devicetree linux-iio 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest1 of 6 patches 2 repliesIn review
  2. v12 of 6 patches 12 repliesSuperseded

Changes in v2 from the cover letter

- Drop two patches which are now queued. (Jonathan)

- Move kerneldoc to separate patch. (Jonathan)

- Move support for continuous conversion mode to separate patch which is marked informational / not for merging. Rename device property to "continuous" for consistency with the existing similar property of drivers/iio/light/us5182d.c. (Rob, Jonathan)

- Rework calculation of raw value in patch [5/6]: Instead of byte-wise mangling, convert the big endian value clocked out by the chip to host byte order and mangle the resulting 32-bit value. Reduces the amount of code and improves readability as the bit numbers referenced in the code comment and datasheet are used verbatim in the code.

- Use switch/case-statement instead of if-clause when applying chip-specific quirks in mcp320x_probe(). (Jonathan)

- Expand code comment explaining the two consecutive conversions in mcp320x_probe(). (Jonathan)

1 of 6 patches is in this archive. The cover letter announces 6.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
4/6dt-bindings: iio: adc: mcp320x: Update for mcp3550/1/3Documentation/devicetree/bindings/iio/adc/mcp320x.txt+14 -02 replies

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchRob Herring
4/6A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] IIO driver for MCP3550/1/3

One speedup, one cleanup, one kerneldoc patch for mcp320x.c plus support for the MCP3550/1/3 used by the "Revolution Pi" family of open source PLCs (https://revolution.kunbus.com/).

Changes since v1:
- Drop two patches which are now queued. (Jonathan)

- Move kerneldoc to separate patch. (Jonathan)

- Move support for continuous conversion mode to separate patch which is marked informational / not for merging. Rename device property to "continuous" for consistency with the existing similar property of drivers/iio/light/us5182d.c. (Rob, Jonathan)

- Rework calculation of raw value in patch [5/6]: Instead of byte-wise mangling, convert the big endian value clocked out by the chip to host byte order and mangle the resulting 32-bit value. Reduces the amount of code and improves readability as the bit numbers referenced in the code comment and datasheet are used verbatim in the code.

- Use switch/case-statement instead of if-clause when applying chip-specific quirks in mcp320x_probe(). (Jonathan)

- Expand code comment explaining the two consecutive conversions in mcp320x_probe(). (Jonathan)

Thanks,

Lukas

Lukas Wunner (6):
iio: adc: mcp320x: Speed up readout of single-channel ADCs
iio: adc: mcp320x: Drop unnecessary of_device_id attributes
iio: adc: mcp320x: Document struct mcp320x
dt-bindings: iio: adc: mcp320x: Update for mcp3550/1/3
iio: adc: mcp320x: Add support for mcp3550/1/3
iio: adc: mcp320x: Support continuous conversion mode

 .../devicetree/bindings/iio/adc/mcp320x.txt        |  23 ++
 drivers/iio/adc/Kconfig                            |   5 +-
 drivers/iio/adc/mcp320x.c                          | 240 ++++++++++++++-------
 3 files changed, 188 insertions(+), 80 deletions(-)
Signature · 1 line
2.11.0