x86/crypto: Fix RBP usage in several crypto .S files
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest12 patches 1 replyIn review
- v112 patches 18 repliesSuperseded
Changes in v2 from the cover letter
- fix performance issues in sha256-avx2-asm.S and sha512-avx2-asm.S (Eric)
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | x86/crypto: Fix RBP usage in blowfish-x86_64-asm_64.Sarch/ | +26 | 0 replies | |
| 2/12 | x86/crypto: Fix RBP usage in camellia-x86_64-asm_64.Sarch/ | +13 | 0 replies | |
| 3/12 | x86/crypto: Fix RBP usage in cast5-avx-x86_64-asm_64.Sarch/ | +30 | 0 replies | |
| 4/12 | x86/crypto: Fix RBP usage in cast6-avx-x86_64-asm_64.Sarch/ | +34 | 0 replies | |
| 5/12 | x86/crypto: Fix RBP usage in des3_ede-asm_64.Sarch/ | +9 | 0 replies | |
| 6/12 | x86/crypto: Fix RBP usage in sha1_avx2_x86_64_asm.Sarch/ | +1 | 0 replies | |
| 7/12 | x86/crypto: Fix RBP usage in sha1_ssse3_asm.Sarch/ | +5 | 0 replies | |
| 8/12 | x86/crypto: Fix RBP usage in sha256-avx-asm.Sarch/ | +7 | 0 replies | |
| 9/12 | x86/crypto: Fix RBP usage in sha256-avx2-asm.Sarch/ | +7 | 0 replies | |
| 10/12 | x86/crypto: Fix RBP usage in sha256-ssse3-asm.Sarch/ | +7 | 0 replies | |
| 11/12 | x86/crypto: Fix RBP usage in sha512-avx2-asm.Sarch/ | +39 | 0 replies | |
| 12/12 | x86/crypto: Fix RBP usage in twofish-avx-x86_64-asm_64.Sarch/ | +6 | 0 replies |
Reviews trailers per patch
All 12 patches have a Reviewed-by or Acked-by.
| Patch | Eric Biggers |
|---|---|
| 1/12 | T-b A-b |
| 2/12 | T-b A-b |
| 3/12 | T-b A-b |
| 4/12 | T-b A-b |
| 5/12 | T-b A-b |
| 6/12 | T-b A-b |
| 7/12 | T-b A-b |
| 8/12 | T-b A-b |
| 9/12 | T-b A-b |
| 10/12 | T-b A-b |
| 11/12 | T-b A-b |
| 12/12 | T-b A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 00/12] x86/crypto: Fix RBP usage in several crypto .S files
v2:
- fix performance issues in sha256-avx2-asm.S and sha512-avx2-asm.S (Eric)
Many of the x86 crypto functions use RBP as a temporary register. This breaks frame pointer convention, and breaks stack traces when unwinding from an interrupt in the crypto code.
Convert most* of them to leave RBP alone.
These pass the crypto boot tests for me. Any further testing would be appreciated!
[*] There are still a few crypto files left that need fixing, but the
fixes weren't trivial and nobody reported unwinder warnings about them yet, so I'm skipping them for now.
Josh Poimboeuf (12):
x86/crypto: Fix RBP usage in blowfish-x86_64-asm_64.S x86/crypto: Fix RBP usage in camellia-x86_64-asm_64.S x86/crypto: Fix RBP usage in cast5-avx-x86_64-asm_64.S x86/crypto: Fix RBP usage in cast6-avx-x86_64-asm_64.S x86/crypto: Fix RBP usage in des3_ede-asm_64.S x86/crypto: Fix RBP usage in sha1_avx2_x86_64_asm.S x86/crypto: Fix RBP usage in sha1_ssse3_asm.S x86/crypto: Fix RBP usage in sha256-avx-asm.S x86/crypto: Fix RBP usage in sha256-avx2-asm.S x86/crypto: Fix RBP usage in sha256-ssse3-asm.S x86/crypto: Fix RBP usage in sha512-avx2-asm.S x86/crypto: Fix RBP usage in twofish-avx-x86_64-asm_64.S
arch/x86/crypto/blowfish-x86_64-asm_64.S | 48 +++++++++--------- arch/x86/crypto/camellia-x86_64-asm_64.S | 26 +++++----- arch/x86/crypto/cast5-avx-x86_64-asm_64.S | 47 +++++++++++------- arch/x86/crypto/cast6-avx-x86_64-asm_64.S | 50 +++++++++++++------ arch/x86/crypto/des3_ede-asm_64.S | 15 +++--- arch/x86/crypto/sha1_avx2_x86_64_asm.S | 4 +- arch/x86/crypto/sha1_ssse3_asm.S | 11 ++--- arch/x86/crypto/sha256-avx-asm.S | 15 +++--- arch/x86/crypto/sha256-avx2-asm.S | 22 +++------ arch/x86/crypto/sha256-ssse3-asm.S | 15 +++--- arch/x86/crypto/sha512-avx2-asm.S | 75 +++++++++++++++-------------- arch/x86/crypto/twofish-avx-x86_64-asm_64.S | 12 ++--- 12 files changed, 184 insertions(+), 156 deletions(-)
Signature · 1 line
2.13.5