Add a valid_cpu_types property
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest6 patches 26 repliesIn review
- v45 patches 14 repliesSuperseded
- v35 patches 9 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 posting 2/2 | 5 patches | 4 replies | Superseded | |
| v2 RFC posting 1/2 | 2 patches | 3 replies | Superseded | |
| v1 RFC | 2 patches | 5 replies | Superseded |
Changes in v5 from the cover letter
- Use cpu_model instead of cpu_type
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | machine: Convert the valid cpu types to use cpu_modelhw/ | +5 | 18 replies | |
| 2/6 | netduino2: Specify the valid CPUshw/ | +9 | 0 replies | |
| 3/6 | bcm2836: Use the Cortex-A7 instead of Cortex-A15hw/ | +1 | 2 replies | |
| 4/6 | raspi: Specify the valid CPUshw/ | +7 | 4 replies | |
| 5/6 | xlnx-zcu102: Specify the valid CPUshw/ | +17 | 0 replies | |
| 6/6 | xilinx_zynq: Specify the valid CPUshw/ | +6 | 0 replies |
Reviews trailers per patch
5 of 6 patches have a Reviewed-by or Acked-by.
| Patch | Philippe Mathieu-Daudé | Igor Mammedov | Eduardo Habkost |
|---|---|---|---|
| 1/6 | |||
| 2/6 | R-b | R-b | |
| 3/6 | R-b | R-b | |
| 4/6 | R-b | ||
| 5/6 | R-b | R-b | |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [Qemu-devel] [PATCH v5 0/6] Add a valid_cpu_types property
There are numorous QEMU machines that only have a single or a handful of valid CPU options. To simplyfy the management of specificying which CPU is/isn't valid let's create a property that can be set in the machine init. We can then check to see if the user supplied CPU is in that list or not.
I have added the valid_cpu_types for some ARM machines only at the moment.
Here is what specifying the CPUs looks like now:
$ aarch64-softmmu/qemu-system-aarch64 -M netduino2 -kernel ./u-boot.elf -nographic -cpu "cortex-m3" -S QEMU 2.10.50 monitor - type 'help' for more information (qemu) info cpus * CPU #0: thread_id=24175 (qemu) q
$ aarch64-softmmu/qemu-system-aarch64 -M netduino2 -kernel ./u-boot.elf -nographic -cpu "cortex-m4" -S QEMU 2.10.50 monitor - type 'help' for more information (qemu) q
$ aarch64-softmmu/qemu-system-aarch64 -M netduino2 -kernel ./u-boot.elf -nographic -cpu "cortex-m5" -S qemu-system-aarch64: unable to find CPU model 'cortex-m5'
$ aarch64-softmmu/qemu-system-aarch64 -M netduino2 -kernel ./u-boot.elf -nographic -cpu "cortex-a9" -S qemu-system-aarch64: Invalid CPU type: cortex-a9-arm-cpu The valid models are: cortex-m3, cortex-m4
V5:
- Use cpu_model instead of cpu_type
V4:
- Rebase
- Remove spaces
V3:
- Make the varialbes static
V2:
- Rebase
- Reorder patches
- Add a Raspberry Pi 2 CPU fix
V1:
- Small fixes to prepare a series instead of RFC
- Add commit messages for the commits
- Expand the machine support to ARM machines
RFC v2:
- Rebase on Igor's work
- Use more QEMUisms inside the code
- List the supported machines in a NULL terminated array
Alistair Francis (6):
machine: Convert the valid cpu types to use cpu_model
netduino2: Specify the valid CPUs
bcm2836: Use the Cortex-A7 instead of Cortex-A15
raspi: Specify the valid CPUs
xlnx-zcu102: Specify the valid CPUs
xilinx_zynq: Specify the valid CPUs
hw/arm/bcm2836.c | 2 +- hw/arm/netduino2.c | 10 +++++++++- hw/arm/raspi.c | 7 +++++++ hw/arm/xilinx_zynq.c | 6 ++++++ hw/arm/xlnx-zcu102.c | 17 +++++++++++++++++ hw/core/machine.c | 11 +++++------ 6 files changed, 45 insertions(+), 8 deletions(-)
Signature · 1 line
2.14.1