Skip to content

Add a valid_cpu_types property

Alistair Francis qemu-devel 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest6 patches 26 repliesIn review
  2. v45 patches 14 repliesSuperseded
  3. v35 patches 9 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v2 posting 2/25 patches4 repliesSuperseded
v2 RFC posting 1/22 patches3 repliesSuperseded
v1 RFC2 patches5 repliesSuperseded

Changes in v5 from the cover letter

- Use cpu_model instead of cpu_type

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6machine: Convert the valid cpu types to use cpu_modelhw/core/machine.c+5 -618 replies
2/6netduino2: Specify the valid CPUshw/arm/netduino2.c+9 -10 replies
3/6bcm2836: Use the Cortex-A7 instead of Cortex-A15hw/arm/bcm2836.c+1 -12 replies
4/6raspi: Specify the valid CPUshw/arm/raspi.c+7 -04 replies
5/6xlnx-zcu102: Specify the valid CPUshw/arm/xlnx-zcu102.c+17 -00 replies
6/6xilinx_zynq: Specify the valid CPUshw/arm/xilinx_zynq.c+6 -00 replies

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéIgor MammedovEduardo Habkost
1/6
2/6R-b R-b
3/6R-b R-b
4/6R-b
5/6R-b R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [Qemu-devel] [PATCH v5 0/6] Add a valid_cpu_types property

There are numorous QEMU machines that only have a single or a handful of valid CPU options. To simplyfy the management of specificying which CPU is/isn't valid let's create a property that can be set in the machine init. We can then check to see if the user supplied CPU is in that list or not.

I have added the valid_cpu_types for some ARM machines only at the moment.

Here is what specifying the CPUs looks like now:

$ aarch64-softmmu/qemu-system-aarch64 -M netduino2 -kernel ./u-boot.elf -nographic -cpu "cortex-m3" -S
QEMU 2.10.50 monitor - type 'help' for more information
(qemu) info cpus
* CPU #0: thread_id=24175
(qemu) q
$ aarch64-softmmu/qemu-system-aarch64 -M netduino2 -kernel ./u-boot.elf -nographic -cpu "cortex-m4" -S
QEMU 2.10.50 monitor - type 'help' for more information
(qemu) q
$ aarch64-softmmu/qemu-system-aarch64 -M netduino2 -kernel ./u-boot.elf -nographic -cpu "cortex-m5" -S
qemu-system-aarch64: unable to find CPU model 'cortex-m5'
$ aarch64-softmmu/qemu-system-aarch64 -M netduino2 -kernel ./u-boot.elf -nographic -cpu "cortex-a9" -S
qemu-system-aarch64: Invalid CPU type: cortex-a9-arm-cpu
The valid models are: cortex-m3, cortex-m4

V5:
- Use cpu_model instead of cpu_type
V4:
- Rebase
- Remove spaces
V3:
- Make the varialbes static
V2:
- Rebase
- Reorder patches
- Add a Raspberry Pi 2 CPU fix
V1:
- Small fixes to prepare a series instead of RFC
- Add commit messages for the commits
- Expand the machine support to ARM machines
RFC v2:
- Rebase on Igor's work
- Use more QEMUisms inside the code
- List the supported machines in a NULL terminated array

Alistair Francis (6):
machine: Convert the valid cpu types to use cpu_model
netduino2: Specify the valid CPUs
bcm2836: Use the Cortex-A7 instead of Cortex-A15
raspi: Specify the valid CPUs
xlnx-zcu102: Specify the valid CPUs
xilinx_zynq: Specify the valid CPUs

 hw/arm/bcm2836.c     |  2 +-
 hw/arm/netduino2.c   | 10 +++++++++-
 hw/arm/raspi.c       |  7 +++++++
 hw/arm/xilinx_zynq.c |  6 ++++++
 hw/arm/xlnx-zcu102.c | 17 +++++++++++++++++
 hw/core/machine.c    | 11 +++++------
 6 files changed, 45 insertions(+), 8 deletions(-)
Signature · 1 line
2.14.1