Skip to content

staging: rtl8723bs: Follow linux-kernel coding style

Harsha Sharma lkml outreachy 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10staging: rtl8723bs: Add spaces around '='drivers/staging/rtl8723bs/os_dep/os_intfs.c+10 -101 reply
2/10staging: rtl8723bs: Add spaces around '+', '|', '*'drivers/staging/rtl8723bs/os_dep/os_intfs.c+6 -61 reply
3/10staging: rtl8723bs: Add spaces around '?', '==', '||', '!='drivers/staging/rtl8723bs/os_dep/os_intfs.c+6 -61 reply
4/10staging: rtl8723bs: Remove unnecessary spaces at the start of linedrivers/staging/rtl8723bs/os_dep/os_intfs.c+1 -11 reply
5/10staging: rtl8723bs: Add space between concatenated stringsdrivers/staging/rtl8723bs/os_dep/os_intfs.c+25 -253 replies
6/10staging: rtl8723bs: Add space after ','drivers/staging/rtl8723bs/os_dep/os_intfs.c+6 -62 replies
7/10staging: rtl8723bs: Removed unneccesary spacedrivers/staging/rtl8723bs/os_dep/os_intfs.c+3 -33 replies
8/10staging: rtl8723bs: Remove unnecessary spacedrivers/staging/rtl8723bs/os_dep/os_intfs.c+3 -30 replies
9/10staging: rtl8723bs: Remove unneccesary braces and change position of open bracedrivers/staging/rtl8723bs/os_dep/os_intfs.c+19 -441 reply
10/10staging: rtl8723bs: Remove unnecessary blank linesdrivers/staging/rtl8723bs/os_dep/os_intfs.c+0 -90 replies

Reviews trailers per patch

5 of 10 patches have a Reviewed-by or Acked-by.

PatchJulia Lawall
1/10A-b
2/10A-b
3/10A-b
4/10A-b
5/10
6/10A-b
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/10] staging: rtl8723bs: Follow linux-kernel coding style

Linux kernel coding style uses one space around most binary and ternary operators and spaces are prohibited at the start of a line. Concatenated strings should have space between elements and space is required after ','. In conditional statements, do not use unnecessary braces where a single statement will do and put the opening brace last on the line, and put the closing brace first. Unnecessary spaces and blank lines should be avoided.

Harsha Sharma (10):
staging: rtl8723bs: Add spaces around '='
staging: rtl8723bs: Add spaces around '+', '|', '*'
staging: rtl8723bs: Add spaces around '?', '==', '||', '!='
staging: rtl8723bs: Remove unnecessary spaces at the start of line
staging: rtl8723bs: Add space between concatenated strings
staging: rtl8723bs: Add space after ','
staging: rtl8723bs: Removed unneccesary space
staging: rtl8723bs: Remove unnecessary space
staging: rtl8723bs: Remove unneccesary braces and change position of
open brace
staging: rtl8723bs: Remove unnecessary blank lines

 drivers/staging/rtl8723bs/os_dep/os_intfs.c | 190 ++++++++++++----------------
 1 file changed, 78 insertions(+), 112 deletions(-)
Signature · 1 line
1.9.1