Skip to content

staging: atomisp: activate ATOMISP2401 support

Vincent Hervieux linux-media lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2staging: atomisp: add menu entries to choose between ATOMISP_2400 and ATOMISP_2401.drivers/staging/media/atomisp/pci/Kconfig drivers/staging/media/atomisp/pci/atomisp2/Makefile+32 -11 reply
2/2staging: atomisp: fix compilation errors in case of ISP2401.drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_acc_types.h +3 more+20 -271 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] staging: atomisp: activate ATOMISP2401 support

Currently atomisp module supports Intel's Baytrail SoC and contains
some compilation switches to support Intel's Cherrytrail SoC instead.
The patchset aims to :
- 1/2: activate ATOMISP2400 or ATOMISP2401 from the menu.
- 2/2: fix compilation errors for ATOMISP2401.
I'm not so confident with patch 2/2, as it is only working around the non declared functions by using the 2400 path. As I couln't find any declaration/definition for the ISP2401 missing functions...So any help would be appreciated. Also patch 2/2 doesn't correct any cosmetic changes reported by checkpatch.pl as explained in TODO step 6.

Vincent Hervieux (2):
staging: atomisp: add menu entries to choose between ATOMISP_2400 and

    ATOMISP_2401.

staging: atomisp: fix compilation errors in case of ISP2401.

 drivers/staging/media/atomisp/pci/Kconfig          | 23 +++++++++++++++++++++
 .../staging/media/atomisp/pci/atomisp2/Makefile    | 10 ++++++++-
 .../media/atomisp/pci/atomisp2/atomisp_cmd.c       |  5 ++---
 .../media/atomisp/pci/atomisp2/atomisp_v4l2.c      |  6 +++++-
 .../pci/atomisp2/css2400/ia_css_acc_types.h        |  1 +
 .../css2400/runtime/debug/src/ia_css_debug.c       |  3 ---
 .../media/atomisp/pci/atomisp2/css2400/sh_css.c    | 24 ++++++++++------------
 .../atomisp/pci/atomisp2/css2400/sh_css_params.c   |  8 +-------
 8 files changed, 52 insertions(+), 28 deletions(-)
Signature · 1 line
2.11.0