Skip to content

Read `packed-refs` using mmap()

Michael Haggerty git 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest21 patches 2 repliesIn review
  2. v221 patches 18 repliesSuperseded
  3. v120 patches 6 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21ref_iterator: keep track of whether the iterator output is orderedrefs.c refs/files-backend.c refs/iterator.c +4 more+46 -190 replies
2/21prefix_ref_iterator: break when we leave the prefixrefs/iterator.c+31 -10 replies
3/21packed_ref_cache: add a backlink to the associated `packed_ref_store`refs/packed-backend.c+16 -70 replies
4/21die_unterminated_line(), die_invalid_line(): new functionsrefs/packed-backend.c+25 -30 replies
5/21read_packed_refs(): use mmap to read the `packed-refs` filerefs/packed-backend.c+32 -100 replies
6/21read_packed_refs(): only check for a header at the top of the filerefs/packed-backend.c+24 -110 replies
7/21read_packed_refs(): make parsing of the header line more robustrefs/packed-backend.c+15 -60 replies
8/21read_packed_refs(): read references with minimal copyingrefs/packed-backend.c+40 -610 replies
9/21packed_ref_cache: remember the file-wide peeling staterefs/packed-backend.c+12 -50 replies
10/21mmapped_ref_iterator: add iterator over a packed-refs filerefs/packed-backend.c+152 -550 replies
11/21mmapped_ref_iterator_advance(): no peeled value for broken refsrefs/packed-backend.c+8 -20 replies
12/21packed-backend.c: reorder some definitionsrefs/packed-backend.c+24 -240 replies
13/21packed_ref_cache: keep the `packed-refs` file mmapped if possibleMakefile config.mak.uname refs/packed-backend.c+152 -420 replies
14/21read_packed_refs(): ensure that references are ordered when readrefs/packed-backend.c+212 -110 replies
15/21packed_ref_iterator_begin(): iterate using `mmapped_ref_iterator`refs/packed-backend.c+106 -30 replies
16/21packed_read_raw_ref(): read the reference from the mmapped bufferrefs/packed-backend.c+9 -50 replies
17/21ref_store: implement `refs_peel_ref()` genericallyrefs.c refs/files-backend.c refs/packed-backend.c +1 more+17 -780 replies
18/21packed_ref_store: get rid of the `ref_cache` entirelyrefs/packed-backend.c+2 -270 replies
19/21ref_cache: remove support for storing peeled valuesrefs/packed-backend.c refs/ref-cache.c refs/ref-cache.h+11 -720 replies
20/21mmapped_ref_iterator: inline into `packed_ref_iterator`refs/packed-backend.c+114 -1700 replies
21/21packed-backend.c: rename a bunch of things and update commentsrefs/packed-backend.c+232 -1900 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 00/21] Read `packed-refs` using mmap()

This is v3 of a patch series that changes the reading and caching of the packed-refs file to use mmap(). Thanks to Stefan, Peff, Dscho, and Junio for their comments about v2. I think I have addressed all of the feedback from v1 [1] and v2 [2].

This version has only minor changes relative to v2:

* Fixed a trivial error in the commit message for patch 08.

* In patch 13:

* In the commit message, explain the appearance of MMAP_TEMPORARY even though it is not yet treated differently than MMAP_NONE.

* In Makefile, don't make USE_WIN32_MMAP imply MMAP_PREVENTS_DELETE.

* Correct the type of a local variable from size_t to ssize_t.

This patch series is also available from my GitHub repo [3] as branch mmap-packed-refs.

[1] http://public-inbox.org/git/[email protected]/
[2] https://public-inbox.org/git/[email protected]/
[3] https://github.com/mhagger/git/

Jeff King (1):
prefix_ref_iterator: break when we leave the prefix

Michael Haggerty (20):
ref_iterator: keep track of whether the iterator output is ordered
packed_ref_cache: add a backlink to the associated packed_ref_store die_unterminated_line(), die_invalid_line(): new functions read_packed_refs(): use mmap to read the packed-refs file read_packed_refs(): only check for a header at the top of the file read_packed_refs(): make parsing of the header line more robust read_packed_refs(): read references with minimal copying
packed_ref_cache: remember the file-wide peeling state
mmapped_ref_iterator: add iterator over a packed-refs file mmapped_ref_iterator_advance(): no peeled value for broken refs packed-backend.c: reorder some definitions
packed_ref_cache: keep the packed-refs file mmapped if possible read_packed_refs(): ensure that references are ordered when read packed_ref_iterator_begin(): iterate using mmapped_ref_iterator packed_read_raw_ref(): read the reference from the mmapped buffer
ref_store: implement refs_peel_ref() generically
packed_ref_store: get rid of the ref_cache entirely
ref_cache: remove support for storing peeled values
mmapped_ref_iterator: inline into packed_ref_iterator packed-backend.c: rename a bunch of things and update comments

 Makefile              |   6 +
 config.mak.uname      |   3 +
 refs.c                |  22 +-
 refs/files-backend.c  |  54 +--
 refs/iterator.c       |  47 ++-
 refs/packed-backend.c | 979 ++++++++++++++++++++++++++++++++++++++------------
 refs/ref-cache.c      |  44 +--
 refs/ref-cache.h      |  35 +-
 refs/refs-internal.h  |  26 +-
 9 files changed, 847 insertions(+), 369 deletions(-)
Signature · 1 line
2.14.1