Skip to content

staging: lustre: fix code styling issues and remove macros without users

Aastha Gupta outreachy 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12staging: lustre: fix incorrect multi-line comment styledrivers/staging/lustre/lustre/include/lustre_errno.h+34 -170 replies
2/12staging: lustre: fix comparisons should place the constant on the right sidedrivers/staging/lustre/lustre/include/lu_object.h+1 -10 replies
3/12staging: lustre: fix macro definitions warningsdrivers/staging/lustre/lustre/include/lu_object.h+8 -60 replies
4/12staging: lustre: drop macro that has no usesdrivers/staging/lustre/lustre/include/lu_object.h+0 -20 replies
5/12staging: lustre: put trailing */ on separate linedrivers/staging/lustre/lustre/include/lustre_dlm_flags.h+4 -20 replies
6/12staging: lustre: fid: fix line over 80 charactersdrivers/staging/lustre/lustre/fid/fid_request.c+2 -10 replies
7/12staging: lustre: fld: fix line over 80 charactersdrivers/staging/lustre/lustre/fld/fld_request.c+2 -10 replies
8/12staging: lustre: ldlm: fix lines over 80 characters in ldlm filesdrivers/staging/lustre/lustre/ldlm/ldlm_extent.c drivers/staging/lustre/lustre/ldlm/ldlm_flock.c drivers/staging/lustre/lustre/ldlm/ldlm_internal.h +5 more+67 -350 replies
9/12staging: lustre: llite: fix lines over 80 characters in llite filesdrivers/staging/lustre/lustre/llite/dcache.c drivers/staging/lustre/lustre/llite/dir.c drivers/staging/lustre/lustre/llite/file.c +10 more+115 -600 replies
10/12staging: lustre: llite: fix identation in dirdrivers/staging/lustre/lustre/llite/dir.c+2 -21 reply
11/12staging: lustre: lllite: fix multi line comments alignment in filedrivers/staging/lustre/lustre/llite/file.c+2 -20 replies
12/12staging: lustre: llite: fix multi line comments styledrivers/staging/lustre/lustre/llite/llite_internal.h drivers/staging/lustre/lustre/llite/rw.c+5 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/12] staging: lustre: fix code styling issues and remove macros without users

These patches fix:
- multi line comment styling
- line over 80 characters
- macro definitions warnings by checkpatch.pl
- drops macros without any users
- Comparisons should place the constant on the right side

This patch series includes all the patches I sent for this driver to show the correct order.

Aastha Gupta (12):
staging: lustre: fix incorrect multi-line comment style
staging: lustre: fix comparisons should place the constant on the
right side
staging: lustre: fix macro definitions warnings
staging: lustre: drop macro that has no uses
staging: lustre: put trailing */ on separate line
staging: lustre: fid: fix line over 80 characters
staging: lustre: fld: fix line over 80 characters
staging: lustre: ldlm: fix lines over 80 characters in ldlm files
staging: lustre: llite: fix lines over 80 characters in llite files
staging: lustre: llite: fix identation in dir
staging: lustre: lllite: fix multi line comments alignment in file
staging: lustre: llite: fix multi line comments style

 drivers/staging/lustre/lustre/fid/fid_request.c    |  3 +-
 drivers/staging/lustre/lustre/fld/fld_request.c    |  3 +-
 drivers/staging/lustre/lustre/include/lu_object.h  | 18 ++++----
 .../lustre/lustre/include/lustre_dlm_flags.h       |  6 ++-
 .../staging/lustre/lustre/include/lustre_errno.h   | 51 ++++++++++++++--------
 drivers/staging/lustre/lustre/ldlm/ldlm_extent.c   |  3 +-
 drivers/staging/lustre/lustre/ldlm/ldlm_flock.c    |  6 ++-
 drivers/staging/lustre/lustre/ldlm/ldlm_internal.h |  4 +-
 drivers/staging/lustre/lustre/ldlm/ldlm_lock.c     | 33 +++++++++-----
 drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c    |  6 ++-
 drivers/staging/lustre/lustre/ldlm/ldlm_pool.c     |  6 ++-
 drivers/staging/lustre/lustre/ldlm/ldlm_request.c  | 41 ++++++++++-------
 drivers/staging/lustre/lustre/ldlm/ldlm_resource.c |  3 +-
 drivers/staging/lustre/lustre/llite/dcache.c       |  9 ++--
 drivers/staging/lustre/lustre/llite/dir.c          | 24 ++++++----
 drivers/staging/lustre/lustre/llite/file.c         | 16 ++++---
 .../staging/lustre/lustre/llite/llite_internal.h   | 25 +++++++----
 drivers/staging/lustre/lustre/llite/llite_lib.c    | 45 ++++++++++++-------
 drivers/staging/lustre/lustre/llite/llite_mmap.c   |  3 +-
 drivers/staging/lustre/lustre/llite/llite_nfs.c    |  3 +-
 drivers/staging/lustre/lustre/llite/namei.c        | 24 ++++++----
 drivers/staging/lustre/lustre/llite/rw.c           | 15 ++++---
 drivers/staging/lustre/lustre/llite/rw26.c         |  3 +-
 drivers/staging/lustre/lustre/llite/statahead.c    | 18 +++++---
 drivers/staging/lustre/lustre/llite/super25.c      |  3 +-
 drivers/staging/lustre/lustre/llite/xattr_cache.c  |  3 +-
 26 files changed, 242 insertions(+), 132 deletions(-)
Signature · 1 line
2.7.4