Skip to content

drm/tilcdc: replace reference/unreference with get/put

Aishwarya Pant dri-devel outreachy 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesIn review
  2. v12 patches 1 replySuperseded

Changes in v2 from the cover letter

- Drop drm_dev_ref after replacing all its usages
- Update the drm subsystem wide cocci script drm-get-put with the new helper for drm_dev_unref to drm_dev_get conversion

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2drm: introduce drm_dev_{get/put} functionsdrivers/gpu/drm/drm_drv.c drivers/gpu/drm/drm_prime.c include/drm/drm_drv.h +1 more+41 -220 replies
2/2drm/tilcdc: replace reference/unreference() with get/putdrivers/gpu/drm/tilcdc/tilcdc_crtc.c drivers/gpu/drm/tilcdc/tilcdc_drv.c+4 -42 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchJyri Sarha
1/2
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] drm/tilcdc: replace reference/unreference with get/put

This patchset introduces drm_dev_get() and drm_dev_put() functions that are intented to be replacements for drm_dev_{ref/unref}.

Then all usages of ref/reference and unref/unreference suffixes are replaced by get/put reference count functions in tilcdc. The following cocci script was used to make the tilcdc patch:

@@
expression ex;
@@

(
-drm_framebuffer_unreference(ex);
+drm_framebuffer_put(ex);
|
-drm_dev_unref(ex);
+drm_dev_put(ex);
|
-drm_framebuffer_reference(ex);
+drm_framebuffer_get(ex);
)

Changes in v2
- Drop drm_dev_ref after replacing all its usages
- Update the drm subsystem wide cocci script drm-get-put with the new helper for drm_dev_unref to drm_dev_get conversion

Aishwarya Pant (2):
drm: introduce drm_dev_{get/put} functions drm/tilcdc: replace reference/unreference() with get/put

 drivers/gpu/drm/drm_drv.c                | 51 ++++++++++++++++++++------------
 drivers/gpu/drm/drm_prime.c              |  2 +-
 drivers/gpu/drm/tilcdc/tilcdc_crtc.c     |  6 ++--
 drivers/gpu/drm/tilcdc/tilcdc_drv.c      |  2 +-
 include/drm/drm_drv.h                    |  5 ++--
 scripts/coccinelle/api/drm-get-put.cocci |  5 ++++
 6 files changed, 45 insertions(+), 26 deletions(-)
Signature · 6 lines
2.7.4

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel