Skip to content

iio: adc: twl4030: Fix some error handling issues in 'twl4030_madc_probe()'

Christophe JAILLET kernel-janitors linux-iio lkml 1 version Applied

Status from this message: Applied to the fixes-togreg-post-rc1 branch of iio.git and marked

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 3 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3iio: adc: twl4030: Fix an error handling path in 'twl4030_madc_probe()'drivers/iio/adc/twl4030-madc.c+4 -21 reply
2/3iio: adc: twl4030: Disable the vusb3v1 rugulator in the error handling path of 'twl4030_madc_probe()'drivers/iio/adc/twl4030-madc.c+3 -11 reply
3/3iio: adc: twl4030: Return an error if we can not enable the vusb3v1 regulator in 'twl4030_madc_probe()'drivers/iio/adc/twl4030-madc.c+3 -11 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] iio: adc: twl4030: Fix some error handling issues in 'twl4030_madc_probe()'

These 3 patches are all related to error hangling in 'twl4030_madc_probe()'. They are also all related to commit 7cc97d77ee8a
("iio: adc: twl4030: Fix ADC[3:6] readings")

The semantic of the patches behing slighly different:
- direct return instead of going through the error handling path
- missing function in the error handling path
- spurious pattern (IMO) if unable to enable a regulator
I have splitted them in 3 parts.

Christophe JAILLET (3):
iio: adc: twl4030: Fix an error handling path in

    'twl4030_madc_probe()'
  iio: adc: twl4030: Disable the vusb3v1 rugulator in the error handling
    path of 'twl4030_madc_probe()'
  iio: adc: twl4030: Return an error if we can not enable the vusb3v1
    regulator in 'twl4030_madc_probe()'
 drivers/iio/adc/twl4030-madc.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)
Signature · 1 line
2.11.0