Skip to content

Remove some of the fprintf(stderr, "*

Alistair Francis qemu-arm qemu-devel qemu-trivial xen-devel 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest27 of 29 patches 13 repliesIn review
  2. v528 of 29 patches 13 repliesSuperseded
  3. v444 of 45 patches 14 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v345 of 46 patches33 repliesSuperseded
v246 of 47 patches53 repliesSuperseded
v18 patches20 repliesSuperseded

Changes in v6 from the cover letter

- Indentation fixes

27 of 29 patches are in this archive. The cover letter announces 29.

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/29audio: Replace AUDIO_FUNC with __func__audio/alsaaudio.c audio/audio.c audio/audio_int.h +8 more+85 -930 replies
2/29Replace all occurances of __FUNCTION__ with __func__hw/arm/nseries.c hw/arm/omap1.c hw/arm/omap2.c +61 more+272 -2720 replies
3/29Fixes after renaming __FUNCTION__ to __func__hw/arm/omap1.c hw/block/onenand.c+4 -60 replies
4/29hw/arm: Replace fprintf(stderr, "*\n" with error_report()hw/arm/armv7m.c hw/arm/boot.c hw/arm/gumstix.c +12 more+77 -749 replies
5/29hw/dma: Replace fprintf(stderr, "*\n" with error_report()hw/dma/omap_dma.c hw/dma/soc_dma.c+32 -301 reply
6/29hw/gpio: Replace fprintf(stderr, "*\n" with error_report()hw/gpio/omap_gpio.c+1 -10 replies
7/29hw/i2c: Replace fprintf(stderr, "*\n" with error_report()hw/i2c/omap_i2c.c+5 -50 replies
9/29hw/ide: Replace fprintf(stderr, "*\n" with error_report()hw/ide/ahci.c hw/ide/core.c+4 -50 replies
10/29hw/intc: Replace fprintf(stderr, "*\n" with error_report()hw/intc/arm_gic_kvm.c hw/intc/omap_intc.c hw/intc/openpic.c +2 more+15 -140 replies
11/29hw/ipmi: Replace fprintf(stderr, "*\n" with error_report()hw/ipmi/ipmi_bmc_extern.c+3 -20 replies
12/29hw/isa: Replace fprintf(stderr, "*\n" with error_report()hw/isa/isa-bus.c+4 -30 replies
13/29hw/lm32: Replace fprintf(stderr, "*\n" with error_report()hw/lm32/lm32_boards.c hw/lm32/milkymist.c+6 -80 replies
14/29hw/mips: Replace fprintf(stderr, "*\n" with error_report()hw/mips/boston.c hw/mips/mips_fulong2e.c hw/mips/mips_jazz.c +3 more+30 -360 replies
15/29hw/moxie: Replace fprintf(stderr, "*\n" with error_report()hw/moxie/moxiesim.c+7 -70 replies
16/29hw/nios2: Replace fprintf(stderr, "*\n" with error_report()hw/nios2/boot.c+1 -10 replies
17/29hw/nvram: Replace fprintf(stderr, "*\n" with error_report()hw/nvram/eeprom93xx.c hw/nvram/fw_cfg.c+6 -50 replies
18/29hw/openrisc: Replace fprintf(stderr, "*\n" with error_report()hw/openrisc/openrisc_sim.c+2 -20 replies
19/29hw/pci*: Replace fprintf(stderr, "*\n" with error_report()hw/pci-host/bonito.c hw/pci/pci.c+9 -90 replies
20/29hw/ppc: Replace fprintf(stderr, "*\n" with error_report()hw/ppc/e500.c hw/ppc/mac_newworld.c hw/ppc/mac_oldworld.c +6 more+49 -480 replies
21/29hw/s390x: Replace fprintf(stderr, "*\n" with error_report()hw/s390x/virtio-ccw.c+3 -22 replies
23/29hw/sd: Replace fprintf(stderr, "*\n" with error_report()hw/sd/pl181.c hw/sd/sd.c+11 -90 replies
24/29hw/sparc*: Replace fprintf(stderr, "*\n" with error_report()hw/sparc/leon3.c hw/sparc/sun4m.c hw/sparc64/niagara.c +1 more+21 -250 replies
25/29hw/ssi: Replace fprintf(stderr, "*\n" with error_report()hw/ssi/omap_spi.c+3 -20 replies
26/29hw/timer: Replace fprintf(stderr, "*\n" with error_report()hw/timer/omap_gptimer.c hw/timer/twl92230.c hw/timer/xilinx_timer.c+12 -130 replies
27/29hw/xen*: Replace fprintf(stderr, "*\n" with error_report()hw/xen/xen-common.c hw/xenpv/xen_domainbuild.c hw/xenpv/xen_machine_pv.c+23 -210 replies
28/29tcg: Replace fprintf(stderr, "*\n" with error_report()cpus.c exec.c tcg/optimize.c +5 more+27 -280 replies
29/29target: Use qemu_log() instead of fprintf(stderr, ...)target/cris/translate.c target/ppc/translate.c target/sh4/translate.c +1 more+14 -330 replies

Reviews trailers per patch

26 of 27 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchEric BlakeThomas HuthGerd HoffmannPhilippe Mathieu-DaudéStefan HajnocziAnthony PERARDJuan QuintelaJohn SnowCornelia HuckMichael WalleHervé PoussineauStafford HorneMarcel ApfelbaumDavid GibsonMark Cave-AylandRichard HendersonEduardo HabkostMarkus Armbruster
SeriesA-b
1/29R-b R-b R-b
2/29R-b R-b R-b R-b R-b
3/29R-b
4/29R-b R-b
5/29R-b R-b
6/29R-b
7/29R-b
9/29R-b A-b
10/29R-b A-b
11/29R-b
12/29R-b
13/29R-b A-b
14/29R-b R-b
15/29R-b R-b
16/29R-b
17/29R-b
18/29R-b A-b
19/29R-b R-b
20/29A-b
21/29R-b
23/29R-b
24/29R-b A-b
25/29R-b
26/29R-b
27/29R-b A-b
28/29A-b
29/29

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 18 reviewers.

Read the v6 thread

Cover letter [Qemu-devel] [PATCH v6 00/29] Remove some of the fprintf(stderr, "*

This is a smaller version of my original series, to hopefully get something merged (although it's getting late for 2.11 now).

Continue on improving QEMUs logging/error messages by removing more fprintf()'s.

Unfortunatley my Coccinelle skills aren't that great so it's all done in some nasty regex and a little bit of manual work.

V6:
- Indentation fixes
V5:
- Small fixes
- Remove a lot of patches
V4:
- Reorder patch 3 (the audio func patch)
- Add all tags
- Small fixes
V3:
- Rebase
- All sorts of style fixes
- Remove "qemu: " prefixes from print messages
V2:
- Fix build issues
- Drop block patches
- Split the hw patches into subdirectories
- Remove AUDIO_FUNC macro as well
- Add some __FUNCTION__ rename fixes in a seperate patch
- Create a qemu_log() conversion patch for target/

Alistair Francis (29):
audio: Replace AUDIO_FUNC with __func__
Replace all occurances of __FUNCTION__ with __func__ Fixes after renaming __FUNCTION__ to __func__ hw/arm: Replace fprintf(stderr, "*\n" with error_report() hw/dma: Replace fprintf(stderr, "*\n" with error_report() hw/gpio: Replace fprintf(stderr, "*\n" with error_report() hw/i2c: Replace fprintf(stderr, "*\n" with error_report() hw/i386: Replace fprintf(stderr, "*\n" with error_report() hw/ide: Replace fprintf(stderr, "*\n" with error_report() hw/intc: Replace fprintf(stderr, "*\n" with error_report() hw/ipmi: Replace fprintf(stderr, "*\n" with error_report() hw/isa: Replace fprintf(stderr, "*\n" with error_report() hw/lm32: Replace fprintf(stderr, "*\n" with error_report() hw/mips: Replace fprintf(stderr, "*\n" with error_report() hw/moxie: Replace fprintf(stderr, "*\n" with error_report() hw/nios2: Replace fprintf(stderr, "*\n" with error_report() hw/nvram: Replace fprintf(stderr, "*\n" with error_report() hw/openrisc: Replace fprintf(stderr, "*\n" with error_report() hw/pci*: Replace fprintf(stderr, "*\n" with error_report() hw/ppc: Replace fprintf(stderr, "*\n" with error_report() hw/s390x: Replace fprintf(stderr, "*\n" with error_report() hw/scsi: Replace fprintf(stderr, "*\n" with error_report() hw/sd: Replace fprintf(stderr, "*\n" with error_report() hw/sparc*: Replace fprintf(stderr, "*\n" with error_report() hw/ssi: Replace fprintf(stderr, "*\n" with error_report() hw/timer: Replace fprintf(stderr, "*\n" with error_report() hw/xen*: Replace fprintf(stderr, "*\n" with error_report()
tcg: Replace fprintf(stderr, "*\n" with error_report()
target: Use qemu_log() instead of fprintf(stderr, ...)

 audio/alsaaudio.c               |  4 +--
 audio/audio.c                   | 40 +++++++++++++--------------
 audio/audio_int.h               |  6 ----
 audio/audio_pt_int.c            | 28 +++++++++----------
 audio/audio_template.h          | 26 +++++++++---------
 audio/dsoundaudio.c             |  2 +-
 audio/mixeng.c                  |  2 +-
 audio/ossaudio.c                | 10 +++----
 audio/paaudio.c                 | 56 ++++++++++++++++++-------------------
 audio/sdlaudio.c                |  2 +-
 audio/wavaudio.c                |  2 +-
 cpus.c                          | 10 +++----
 exec.c                          | 20 +++++++-------
 hw/arm/armv7m.c                 |  2 +-
 hw/arm/boot.c                   | 37 ++++++++++++-------------
 hw/arm/gumstix.c                | 13 +++++----
 hw/arm/mainstone.c              |  7 +++--
 hw/arm/musicpal.c               |  2 +-
 hw/arm/nseries.c                |  2 +-
 hw/arm/omap1.c                  | 49 ++++++++++++++++-----------------
 hw/arm/omap2.c                  | 23 ++++++++--------
 hw/arm/omap_sx1.c               |  8 ++----
 hw/arm/palm.c                   | 20 +++++++-------
 hw/arm/pxa2xx.c                 | 53 +++++++++++++++++------------------
 hw/arm/pxa2xx_gpio.c            |  6 ++--
 hw/arm/pxa2xx_pic.c             |  4 +--
 hw/arm/stellaris.c              |  3 +-
 hw/arm/tosa.c                   | 26 +++++++++---------
 hw/arm/versatilepb.c            |  2 +-
 hw/arm/vexpress.c               |  8 +++---
 hw/arm/z2.c                     |  6 ++--
 hw/audio/hda-codec.c            | 10 +++----
 hw/audio/intel-hda.c            | 28 +++++++++----------
 hw/audio/wm8750.c               |  4 +--
 hw/block/nand.c                 |  4 +--
 hw/block/onenand.c              |  8 +++---
 hw/bt/core.c                    | 10 +++----
 hw/bt/hci-csr.c                 | 14 +++++-----
 hw/bt/hci.c                     | 26 +++++++++---------
 hw/bt/hid.c                     |  2 +-
 hw/bt/l2cap.c                   | 22 +++++++--------
 hw/bt/sdp.c                     |  6 ++--
 hw/display/blizzard.c           | 18 ++++++------
 hw/display/omap_dss.c           |  6 ++--
 hw/display/pxa2xx_lcd.c         | 14 +++++-----
 hw/display/qxl-render.c         |  6 ++--
 hw/display/qxl.h                |  2 +-
 hw/display/tc6393xb.c           |  2 +-
 hw/display/xenfb.c              |  2 +-
 hw/dma/omap_dma.c               | 38 +++++++++++++------------
 hw/dma/pxa2xx_dma.c             | 14 +++++-----
 hw/dma/soc_dma.c                | 36 ++++++++++++------------
 hw/gpio/max7310.c               |  8 +++---
 hw/gpio/omap_gpio.c             |  2 +-
 hw/i2c/omap_i2c.c               | 10 +++----
 hw/i386/kvm/apic.c              | 15 +++++-----
 hw/i386/kvm/clock.c             |  7 +++--
 hw/i386/kvm/i8254.c             | 11 ++++----
 hw/i386/kvm/i8259.c             |  5 ++--
 hw/i386/kvm/ioapic.c            |  5 ++--
 hw/i386/multiboot.c             | 21 +++++++-------
 hw/i386/pc.c                    | 24 ++++++++--------
 hw/i386/pc_piix.c               |  2 +-
 hw/i386/pc_sysfw.c              |  4 +--
 hw/i386/xen/xen-hvm.c           | 34 ++++++++++++-----------
 hw/i386/xen/xen-mapcache.c      | 12 ++++----
 hw/i386/xen/xen_apic.c          |  3 +-
 hw/ide/ahci.c                   |  6 ++--
 hw/ide/core.c                   |  3 +-
 hw/ide/microdrive.c             |  4 +--
 hw/input/lm832x.c               |  6 ++--
 hw/input/pxa2xx_keypad.c        |  6 ++--
 hw/input/tsc2005.c              |  8 +++---
 hw/input/tsc210x.c              |  4 +--
 hw/intc/arm_gic_kvm.c           | 12 ++++----
 hw/intc/omap_intc.c             |  4 +--
 hw/intc/openpic.c               |  1 +
 hw/intc/openpic_kvm.c           |  8 +++---
 hw/intc/s390_flic_kvm.c         |  4 +--
 hw/ipmi/ipmi_bmc_extern.c       |  5 ++--
 hw/isa/isa-bus.c                |  7 +++--
 hw/isa/vt82c686.c               |  2 +-
 hw/lm32/lm32_boards.c           |  7 ++---
 hw/lm32/milkymist.c             |  7 ++---
 hw/mips/boston.c                |  4 +--
 hw/mips/gt64xxx_pci.c           |  2 +-
 hw/mips/mips_fulong2e.c         | 13 ++++-----
 hw/mips/mips_jazz.c             |  4 +--
 hw/mips/mips_malta.c            | 16 +++++------
 hw/mips/mips_mipssim.c          | 11 ++++----
 hw/mips/mips_r4k.c              | 18 ++++++------
 hw/misc/cbus.c                  | 12 ++++----
 hw/misc/omap_clk.c              |  4 +--
 hw/misc/omap_gpmc.c             |  6 ++--
 hw/misc/omap_l4.c               |  4 +--
 hw/misc/omap_sdrc.c             |  2 +-
 hw/misc/omap_tap.c              |  6 ++--
 hw/misc/tmp105.c                |  2 +-
 hw/moxie/moxiesim.c             | 14 +++++-----
 hw/nios2/boot.c                 |  2 +-
 hw/nvram/eeprom93xx.c           |  7 +++--
 hw/nvram/fw_cfg.c               |  4 +--
 hw/openrisc/openrisc_sim.c      |  4 +--
 hw/pci-host/bonito.c            |  8 +++---
 hw/pci/pci.c                    | 12 ++++----
 hw/ppc/e500.c                   | 28 +++++++++----------
 hw/ppc/mac_newworld.c           |  2 +-
 hw/ppc/mac_oldworld.c           |  2 +-
 hw/ppc/mpc8544_guts.c           |  7 +++--
 hw/ppc/ppc405_boards.c          | 15 ++++------
 hw/ppc/ppc440_bamboo.c          | 27 +++++++++---------
 hw/ppc/ppc4xx_pci.c             |  3 +-
 hw/ppc/prep.c                   |  4 +--
 hw/ppc/virtex_ml507.c           |  9 +++---
 hw/s390x/virtio-ccw.c           |  5 ++--
 hw/scsi/lsi53c895a.c            |  4 +--
 hw/scsi/spapr_vscsi.c           | 61 +++++++++++++++++++++--------------------
 hw/scsi/virtio-scsi-dataplane.c |  7 ++---
 hw/sd/pl181.c                   |  5 ++--
 hw/sd/pxa2xx_mmci.c             |  6 ++--
 hw/sd/sd.c                      | 15 +++++-----
 hw/sparc/leon3.c                | 16 +++++------
 hw/sparc/sun4m.c                | 16 +++++------
 hw/sparc64/niagara.c            |  4 +--
 hw/sparc64/sun4u.c              | 10 +++----
 hw/ssi/omap_spi.c               |  9 +++---
 hw/timer/omap_gptimer.c         | 12 ++++----
 hw/timer/twl92230.c             |  7 ++---
 hw/timer/xilinx_timer.c         | 10 +++----
 hw/usb/desc.c                   |  2 +-
 hw/usb/dev-bluetooth.c          |  4 +--
 hw/usb/hcd-musb.c               |  4 +--
 hw/usb/tusb6010.c               | 14 +++++-----
 hw/xen/xen-common.c             | 11 ++++----
 hw/xenpv/xen_domainbuild.c      | 32 ++++++++++-----------
 hw/xenpv/xen_machine_pv.c       |  9 +++---
 include/hw/arm/omap.h           | 10 +++----
 include/hw/arm/sharpsl.h        |  2 +-
 memory_mapping.c                |  2 +-
 migration/block.c               |  4 +--
 target/cris/translate.c         |  2 +-
 target/ppc/translate.c          | 36 +++++++-----------------
 target/sh4/translate.c          |  7 ++---
 target/unicore32/translate.c    |  2 +-
 tcg/optimize.c                  |  8 +++---
 tcg/tcg.c                       |  2 +-
 tcg/tcg.h                       |  3 +-
 tcg/tci.c                       |  3 +-
 tcg/tci/tcg-target.inc.c        |  7 ++---
 ui/cursor.c                     |  6 ++--
 ui/spice-display.c              |  4 +--
 vl.c                            |  2 +-
 152 files changed, 802 insertions(+), 821 deletions(-)
Signature · 1 line
2.14.1