Skip to content

new mlx4 datapath bypassing ibverbs

Adrien Mazarguil dpdk-dev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest5 patches 5 repliesIn review
  2. v55 patches 0 repliesSuperseded
  3. v36 patches 0 repliesSuperseded

Changes in v6 from the cover letter

- Updated features documentation (mlx4.ini) in the relevant patches.
- Rebased on the latest changes brought by RSS support v2 series.

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5net/mlx4: add Tx bypassing Verbsdrivers/net/mlx4/mlx4_prm.h drivers/net/mlx4/mlx4_rxtx.c drivers/net/mlx4/mlx4_rxtx.h +1 more+490 -1170 replies
2/5net/mlx4: add Rx bypassing Verbsdoc/guides/nics/features/mlx4.ini drivers/net/mlx4/mlx4_rxq.c drivers/net/mlx4/mlx4_rxtx.c +1 more+242 -1550 replies
3/5net/mlx4: restore Tx checksum offloadsdoc/guides/nics/features/mlx4.ini drivers/net/mlx4/mlx4.c drivers/net/mlx4/mlx4.h +5 more+48 -00 replies
4/5net/mlx4: restore Rx offloadsdoc/guides/nics/features/mlx4.ini drivers/net/mlx4/mlx4_ethdev.c drivers/net/mlx4/mlx4_prm.h +3 more+158 -30 replies
5/5net/mlx4: add loopback Tx from VFdrivers/net/mlx4/mlx4_rxtx.c drivers/net/mlx4/mlx4_rxtx.h drivers/net/mlx4/mlx4_txq.c+24 -120 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchAdrien Mazarguil
1/5A-b
2/5A-b
3/5A-b
4/5A-b
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/5] new mlx4 datapath bypassing ibverbs

Hopefully the last iteration for this series.

v6 (Adrien):
- Updated features documentation (mlx4.ini) in the relevant patches.
- Rebased on the latest changes brought by RSS support v2 series.

v5 (Ophir & Adrien):
- Merged Rx scatter/Tx gather code back into individual Rx/Tx commits for consistency due to a couple of issues with gather-less Tx.
- Rebased on top of the latest mlx4 control path changes (RSS support).

v4 (Ophir):
- Split "net/mlx4: restore Rx scatter support" commit from "net/mlx4:
restore full Rx support bypassing Verbs" commit

v3 (Adrien):
- Drop a few unrelated or unnecessary changes such as the removal of MLX4_PMD_TX_MP_CACHE.
- Move device checksum support detection code to its previous location.
- Fix include guard in mlx4_prm.h.
- Reorder #includes alphabetically.
- Replace MLX4_TRANSPOSE() macro with documented inline function.
- Remove extra spaces and blank lines.
- Use uint8_t * instead of char * for buffers.
- Replace mlx4_get_cqe() macro with a documented inline function.
- Replace several unsigned int with uint32_t.
- Add consistency to field names (sge_n => sges_n).
- Make mbuf size checks in RX queue setup function similar to mlx5.
- Update various comments.
- Fix indentation.
- Replace run-time endian conversion with static ones where possible.
- Reorder fields in struct rxq and struct txq for consistency, remove one level of unnecessary inner structures.
- Fix memory leak on Tx bounce buffer.
- Update commit logs.
- Fix remaining checkpatch warnings.

v2 (Matan):
Rearange patches.
Semantics.
Enhancements.
Fix compilation issues.

Moti Haimovsky (5):
net/mlx4: add Tx bypassing Verbs
net/mlx4: add Rx bypassing Verbs
net/mlx4: restore Tx checksum offloads
net/mlx4: restore Rx offloads
net/mlx4: add loopback Tx from VF

 doc/guides/nics/features/mlx4.ini |   6 +
 drivers/net/mlx4/mlx4.c           |  11 +
 drivers/net/mlx4/mlx4.h           |   2 +
 drivers/net/mlx4/mlx4_ethdev.c    |  10 +
 drivers/net/mlx4/mlx4_prm.h       | 151 +++++++
 drivers/net/mlx4/mlx4_rxq.c       | 156 +++++--
 drivers/net/mlx4/mlx4_rxtx.c      | 768 ++++++++++++++++++++++++---------
 drivers/net/mlx4/mlx4_rxtx.h      |  54 +--
 drivers/net/mlx4/mlx4_txq.c       |  63 +++
 9 files changed, 948 insertions(+), 273 deletions(-)
 create mode 100644 drivers/net/mlx4/mlx4_prm.h
Signature · 1 line
2.1.4