Skip to content

drm/amd/powerplay: Fix coccinelle and checkpatch issues

Georgiana Chelu dri-devel outreachy 2 versions – Applied

Status from this message: Applied the series. Thanks you!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 1 replyApplied
  2. v13 patches 2 repliesSuperseded

Changes in v2 from the cover letter

* adjusted the subject prefix of the patches
* added the cocci script used to generate the patches

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3drm/amd/powerplay: Don't cast kzalloc() return valuedrivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c+8 -160 replies
2/3drm/amd/powerplay: Remove useless variabledrivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c+1 -20 replies
3/3drm/amd/powerplay: Place the constant on the right side of the testdrivers/gpu/drm/amd/powerplay/hwmgr/vega10_processpptables.c+4 -41 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] drm/amd/powerplay: Fix coccinelle and checkpatch issues

The first two patches fix coccinelle issues and the last patch fix a checkpatch issue.

First patch: The return value of kzalloc does not need a cast because the assignment operator will take care of this.

Second patch: The 'result' variable does not change its value until the end of the function. Instead of using the variable, return its default value.

Third patch: Placing the constant on the right side will make the code easier to read, as most of the people read from right to left.

Changes in v2:
* adjusted the subject prefix of the patches
* added the cocci script used to generate the patches

Georgiana Chelu (3):
drm/amd/powerplay: Don't cast kzalloc() return value drm/amd/powerplay: Remove useless variable drm/amd/powerplay: Place the constant on the right side of the test

 .../amd/powerplay/hwmgr/vega10_processpptables.c   | 35 ++++++++--------------
 1 file changed, 13 insertions(+), 22 deletions(-)
Signature · 1 line
2.11.0