rtnetlink: a bunch of fixes for userspace notifications in changing dev properties
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 patches 11 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | rtnetlink: bring NETDEV_CHANGEMTU event process back in rtnetlink_eventnet/ | +1 | 0 replies | |
| 2/6 | rtnetlink: bring NETDEV_CHANGE_TX_QUEUE_LEN event process back in rtnetlink_eventnet/ | +1 | 1 reply | |
| 3/6 | rtnetlink: bring NETDEV_POST_TYPE_CHANGE event process back in rtnetlink_eventnet/ | +1 | 1 reply | |
| 4/6 | rtnetlink: bring NETDEV_CHANGEUPPER event process back in rtnetlink_eventnet/ | +1 | 1 reply | |
| 5/6 | rtnetlink: check DO_SETLINK_NOTIFY correctly in do_setlinknet/ | +1 | 10 replies | |
| 6/6 | rtnetlink: do not set notification for tx_queue_len in do_setlinknet/ | +1 | 1 reply |
Reviews trailers per patch
5 of 6 patches have a Reviewed-by or Acked-by.
| Patch | David Ahern | Nicolas Dichtel |
|---|---|---|
| 1/6 | ||
| 2/6 | A-b | |
| 3/6 | A-b | |
| 4/6 | A-b | |
| 5/6 | A-b | A-b |
| 6/6 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net 0/6] rtnetlink: a bunch of fixes for userspace notifications in changing dev properties
Whenever any property of a link, address, route, etc. changes by whatever way, kernel should notify the programs that listen for such events in userspace.
The patchet "rtnetlink: Cleanup user notifications for netdev events" tried to fix a redundant notifications issue, but it also introduced a side effect.
After that, user notifications could only be sent when changing dev properties via netlink api. As it removed some events process in rtnetlink_event where the notifications was sent to users.
It resulted in no notification generated when dev properties are changed via other ways, like ioctl, sysfs, etc. It may cause some user programs doesn't work as expected because of the missing notifications.
This patchset will fix it by bringing some of these netdev events back and also fix the old redundant notifications issue with a proper way.
Xin Long (6):
rtnetlink: bring NETDEV_CHANGEMTU event process back in
rtnetlink_event
rtnetlink: bring NETDEV_CHANGE_TX_QUEUE_LEN event process back in
rtnetlink_event
rtnetlink: bring NETDEV_POST_TYPE_CHANGE event process back in
rtnetlink_event
rtnetlink: bring NETDEV_CHANGEUPPER event process back in
rtnetlink_event
rtnetlink: check DO_SETLINK_NOTIFY correctly in do_setlink
rtnetlink: do not set notification for tx_queue_len in do_setlink
net/core/rtnetlink.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
Signature · 1 line
2.1.0