Skip to content

Fix for BPF devmap percpu allocation splat

Daniel Borkmann lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 15 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3mm, percpu: add support for __GFP_NOWARN flagmm/percpu.c+10 -51 reply
2/3bpf: fix splat for illegal devmap percpu allocationkernel/bpf/devmap.c+3 -22 replies
3/3bpf: do not test for PCPU_MIN_UNIT_SIZE before percpu allocationskernel/bpf/arraymap.c kernel/bpf/hashtab.c+1 -52 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchAlexei StarovoitovJohn Fastabend
1/3A-b
2/3A-b A-b
3/3A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net 0/3] Fix for BPF devmap percpu allocation splat

The set fixes a splat in devmap percpu allocation when we alloc the flush bitmap. Patch 1 is a prerequisite for the fix in patch 2, patch 1 is rather small, so if this could be routed via -net, for example, with Tejun's Ack that would be good. Patch 3 gets rid of remaining PCPU_MIN_UNIT_SIZE checks, which are percpu allocator internals and should not be used.

Thanks!

Daniel Borkmann (3):
mm, percpu: add support for __GFP_NOWARN flag
bpf: fix splat for illegal devmap percpu allocation
bpf: do not test for PCPU_MIN_UNIT_SIZE before percpu allocations

 kernel/bpf/arraymap.c |  2 +-
 kernel/bpf/devmap.c   |  5 +++--
 kernel/bpf/hashtab.c  |  4 ----
 mm/percpu.c           | 15 ++++++++++-----
 4 files changed, 14 insertions(+), 12 deletions(-)
Signature · 1 line
1.9.3