Skip to content

Topstar U931/RVP7 ACPI LED Workaround

Guillaume Douézan-Grard lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest7 patches 1 replyIn review
  2. v47 patches 4 repliesSuperseded
  3. v36 patches 3 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v24 patches10 repliesSuperseded
v14 patches1 replySuperseded

Changes in v5 from the cover letter

* move module description comment change from patch 5 to 4,
* fix SDPX identifiers mismatch.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7platform/x86: topstar-laptop: revert "convert to module_acpi_driver()"drivers/platform/x86/topstar-laptop.c+21 -10 replies
2/7platform/x86: topstar-laptop: use consistent naming schemedrivers/platform/x86/topstar-laptop.c+41 -410 replies
3/7platform/x86: topstar-laptop: split ACPI events and input handlingdrivers/platform/x86/topstar-laptop.c+71 -380 replies
4/7platform/x86: topstar-laptop: add platform devicedrivers/platform/x86/topstar-laptop.c+58 -30 replies
5/7platform/x86: topstar-laptop: add Topstar U931/RVP7 WLAN LED workarounddrivers/platform/x86/Kconfig drivers/platform/x86/topstar-laptop.c+110 -00 replies
6/7platform/x86: topstar-laptop: update copyright and fix some commentsdrivers/platform/x86/topstar-laptop.c+3 -10 replies
7/7platform/x86: topstar-laptop: replace licence text with SPDX tagdrivers/platform/x86/topstar-laptop.c+1 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH v5 0/7] Topstar U931/RVP7 ACPI LED Workaround

Hi Andy,

Thank you for your review. Changes since the previous submission are highlighted below.

On Topstar U931/RVP7 Notebooks, an issue prevents the WLAN toggle key from being properly managed by the Embedded Controller and successfully disconnect the adapter. A specific ACPI method allows to toggle the WLAN LED state regardless.

Based on a DMI check, the LED is registered within the corresponding subsystem, making possible to use a software-based trigger (rfkill for instance, to synchronize the LED with the network interface state).

Thank you for your time,

--
Guillaume Douézan-Grard

Changes since v4:

* move module description comment change from patch 5 to 4,
* fix SDPX identifiers mismatch.

Changes since v3:

* fix revert commit message format and wrapping,
* update module description while actually doing the changes,
* switch to SDPX identifiers.

Changes since v2:

* revert an older conversion from a generic module to an acpi driver module instead of undoing it manually,
* separate commits for the renaming and the spliting phases,
* DMI-based check instead of a module parameter,
* copyright and minor fixes put at the end.

Changes since v1:

* leave devices names unchanged for ABI compatibility,
* fix label names,
* separate module authors definition,
* add commit description to Patch 3.

Guillaume Douézan-Grard (7):
platform/x86: topstar-laptop: revert "convert to module_acpi_driver()" platform/x86: topstar-laptop: use consistent naming scheme platform/x86: topstar-laptop: split ACPI events and input handling platform/x86: topstar-laptop: add platform device platform/x86: topstar-laptop: add Topstar U931/RVP7 WLAN LED
workaround
platform/x86: topstar-laptop: update copyright and fix some comments platform/x86: topstar-laptop: replace licence text with SPDX tag

 drivers/platform/x86/Kconfig          |   2 +
 drivers/platform/x86/topstar-laptop.c | 363 +++++++++++++++++++++++++++-------
 2 files changed, 291 insertions(+), 74 deletions(-)
Signature · 1 line
2.16.1