Skip to content

Don't write headers if BDS is INACTIVE

Jeff Cody qemu-devel 4 versions – Applied

Status from this message: Thanks, applied to my block branch:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 4 repliesApplied
  2. v34 patches 2 repliesSuperseded
  3. v23 patches 6 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches4 repliesSuperseded

Changes from v1->v2 from the cover letter

* Drop previous parallels patches, just check BDRV_O_INACTIVE now (Kevin)

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/4block/vhdx.c: Don't blindly update the headerblock/vhdx.c+0 -71 reply
2/4block/parallels: Do not update header or truncate image when INMIGRATEblock/parallels.c+2 -50 replies
3/4block/parallels: add migration blockerblock/parallels.c+15 -00 replies
4/4qemu-iotests: update unsupported image formats in 194tests/qemu-iotests/194+1 -10 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchFam ZhengAlexey KardashevskiyStefan HajnocziDenis V. Lunev
SeriesR-b R-b
1/4T-b
2/4T-b
3/4R-b
4/4T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v4 thread

Cover letter [Qemu-devel] [PATCH v4 0/4] Don't write headers if BDS is INACTIVE

Changes from v3->v4:

Patch 3: Add migrate_del_blocker and error_free (Thanks Stefan)

git-backport-diff -r qemu/master.. -u ba11b69

001/4:[----] [--] 'block/vhdx.c: Don't blindly update the header' 002/4:[----] [--] 'block/parallels: Do not update header or truncate image when INMIGRATE' 003/4:[0003] [FC] 'block/parallels: add migration blocker'
004/4:[----] [--] 'qemu-iotests: update unsupported image formats in 194'

Changes from v2->v3:

Patch 2: Uh... fix that misspelling. Thanks Stefan :) Patch 3: New patch to block migration in parallels

git-backport-diff -r qemu/master.. -u 6dc6acb

001/4:[----] [--] 'block/vhdx.c: Don't blindly update the header' 002/4:[----] [--] 'block/parallels: Do not update header or truncate image when INMIGRATE' 003/4:[down] 'block/parallels: add migration blocker'
004/4:[----] [--] 'qemu-iotests: update unsupported image formats in 194'

Changes from v1->v2:

* Drop previous parallels patches, just check BDRV_O_INACTIVE now (Kevin)

git-backport-diff -r qemu/master.. -u github/master
Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/3:[----] [--] 'block/vhdx.c: Don't blindly update the header' 002/3:[down] 'block/parallals: Do not update header or truncate image when INMIGRATE' 003/3:[----] [--] 'qemu-iotests: update unsupported image formats in 194'

v1:

VHDX and Parallels both blindly write headers to the image file if the images are opened R/W. This causes an assert if the QEMU run state is INMIGRATE.

Jeff Cody (4):
block/vhdx.c: Don't blindly update the header block/parallels: Do not update header or truncate image when INMIGRATE block/parallels: add migration blocker
qemu-iotests: update unsupported image formats in 194

 block/parallels.c      | 22 +++++++++++++++++-----
 block/vhdx.c           |  7 -------
 tests/qemu-iotests/194 |  2 +-
 3 files changed, 18 insertions(+), 13 deletions(-)
Signature · 1 line
2.9.5