Skip to content

Device fixes and cleanups

David Sterba linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 15 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11btrfs: add missing device::flush_bio putsfs/btrfs/volumes.c+10 -03 replies
2/11btrfs: rename device free rcu helper to free_device_rcufs/btrfs/volumes.c+5 -50 replies
3/11btrfs: introduce free_device helperfs/btrfs/volumes.c+14 -20 replies
4/11btrfs: use free_device where opencodedfs/btrfs/volumes.c+11 -281 reply
5/11btrfs: simplify exit paths in btrfs_init_new_devicefs/btrfs/volumes.c+3 -41 reply
6/11btrfs: document device lockingfs/btrfs/volumes.c+66 -08 replies
7/11btrfs: dev_alloc_list is not protected by RCU, use normal list_delfs/btrfs/volumes.c+1 -10 replies
8/11btrfs: simplify btrfs_close_bdevfs/btrfs/volumes.c+5 -30 replies
9/11btrfs: switch to RCU for device traversal in btrfs_ioctl_dev_infofs/btrfs/ioctl.c+2 -50 replies
10/11btrfs: switch to RCU for device traversal in btrfs_ioctl_fs_infofs/btrfs/ioctl.c+4 -40 replies
11/11btrfs: use non-RCU list traversal in write_all_supers calleesfs/btrfs/disk-io.c+5 -42 replies

Reviews trailers per patch

3 of 11 patches have a Reviewed-by or Acked-by.

PatchNikolay BorisovAnand Jain
1/11R-b R-b
2/11
3/11
4/11R-b
5/11R-b
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/11] Device fixes and cleanups

Cleanups for device locking and documentation of the various mutexes. Patch 1 is a bugfix that could be considered for 4.15 as we could leak bios under some rare condition, but so far this hasn't been reported so I don't rate is as critical.

David Sterba (11):
btrfs: add missing device::flush_bio puts
btrfs: rename device free rcu helper to free_device_rcu
btrfs: introduce free_device helper
btrfs: use free_device where opencoded
btrfs: simplify exit paths in btrfs_init_new_device
btrfs: document device locking
btrfs: dev_alloc_list is not protected by RCU, use normal list_del
btrfs: simplify btrfs_close_bdev
btrfs: switch to RCU for device traversal in btrfs_ioctl_dev_info
btrfs: switch to RCU for device traversal in btrfs_ioctl_fs_info
btrfs: use non-RCU list traversal in write_all_supers callees

 fs/btrfs/disk-io.c |   9 ++--
 fs/btrfs/ioctl.c   |  15 +++---
 fs/btrfs/volumes.c | 134 ++++++++++++++++++++++++++++++++++++++++-------------
 3 files changed, 114 insertions(+), 44 deletions(-)
Signature · 1 line
2.14.0