Skip to content

drm/edid and drivers: ELD refactoring

Jani Nikula dri-devel intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7drm/edid: use macros for ELD offsets and valuesdrivers/gpu/drm/drm_edid.c+14 -130 replies
2/7drm/edid: set ELD connector type in drm_edid_to_eld()drivers/gpu/drm/drm_edid.c+7 -20 replies
3/7drm/i915: remove redundant ELD connector type updatedrivers/gpu/drm/i915/intel_modes.c+0 -170 replies
4/7drm/edid: abstract connector ELD clearingdrivers/gpu/drm/drm_edid.c+13 -80 replies
5/7drm/edid: build ELD in drm_add_edid_modes()drivers/gpu/drm/drm_edid.c+6 -20 replies
6/7drm/drivers: drop redundant drm_edid_to_eld() callsdrivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c drivers/gpu/drm/bridge/analogix-anx78xx.c drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +11 more+2 -213 replies
7/7drm/edid: make drm_edid_to_eld() staticdrivers/gpu/drm/drm_edid.c include/drm/drm_edid.h include/drm/drm_modeset_helper_vtables.h+2 -70 replies

Reviews trailers per patch

1 of 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchVille SyrjäläEric AnholtAlex DeucherArchit TanejaThierry Reding
SeriesR-b R-b A-b
1/7
2/7
3/7
4/7
5/7
6/7A-b A-b
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [PATCH 0/7] drm/edid and drivers: ELD refactoring

We were recently bitten by drm_edid_to_eld() clearing the connector type, and us failing to set it back for DP. Here's a few ELD related patches to try to unify ELD handling and make it a bit simpler for drivers to get it right.

Apologies for the massive Cc list; it's the maintainers of all drivers that call drm_edid_to_eld().

I'm open to splitting up patch 6 to driver specific patches as needed, but I'd think it would be just fine to merge via drm-misc as-is too.

BR,
Jani.

Cc Alex Deucher <[email protected]>
Cc Christian König <[email protected]>
Cc Archit Taneja <[email protected]>
Cc Andrzej Hajda <[email protected]>
Cc Russell King <[email protected]>
Cc Philipp Zabel <[email protected]>
Cc Ben Skeggs <[email protected]>
Cc Mark Yao <[email protected]>
Cc Benjamin Gaignard <[email protected]>
Cc Vincent Abriou <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Eric Anholt <[email protected]>

Jani Nikula (7):
drm/edid: use macros for ELD offsets and values drm/edid: set ELD connector type in drm_edid_to_eld() drm/i915: remove redundant ELD connector type update drm/edid: abstract connector ELD clearing drm/edid: build ELD in drm_add_edid_modes() drm/drivers: drop redundant drm_edid_to_eld() calls drm/edid: make drm_edid_to_eld() static

 drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c |  1 -
 drivers/gpu/drm/bridge/analogix-anx78xx.c      |  2 -
 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c      |  2 -
 drivers/gpu/drm/drm_edid.c                     | 70 +++++++++++++++-----------
 drivers/gpu/drm/i2c/tda998x_drv.c              |  1 -
 drivers/gpu/drm/i915/intel_dp.c                |  1 -
 drivers/gpu/drm/i915/intel_modes.c             | 18 -------
 drivers/gpu/drm/mediatek/mtk_hdmi.c            |  1 -
 drivers/gpu/drm/nouveau/nv50_display.c         |  5 +-
 drivers/gpu/drm/radeon/radeon_connectors.c     |  1 -
 drivers/gpu/drm/radeon/radeon_dp_mst.c         |  1 -
 drivers/gpu/drm/rockchip/cdn-dp-core.c         |  4 +-
 drivers/gpu/drm/sti/sti_hdmi.c                 |  1 -
 drivers/gpu/drm/tegra/output.c                 |  1 -
 drivers/gpu/drm/vc4/vc4_hdmi.c                 |  1 -
 include/drm/drm_edid.h                         |  1 -
 include/drm/drm_modeset_helper_vtables.h       |  3 --
 17 files changed, 44 insertions(+), 70 deletions(-)
Signature · 6 lines
2.11.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx