Misc qcow2 corruption checks
Status from this message: Thanks, applied to my block branch:
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest7 patches 10 repliesApplied
- v14 patches 8 repliesSuperseded
Changes in v2 from the cover letter
- Use goto fail in the l2_allocate() check [Max]
- Add check and test case for allocation of compressed clusters [Max]
- Add test case for header.refcount_table_offset == 0
- Add overlap checks to qcow2_crypto_hdr_init_func() [Max]
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | qcow2: Prevent allocating refcount blocks at offset 0block/ tests/ tests/ | +26 | 0 replies | |
| 2/7 | qcow2: Prevent allocating L2 tables at offset 0block/ tests/ tests/ | +21 | 0 replies | |
| 3/7 | qcow2: Prevent allocating compressed clusters at offset 0block/ tests/ tests/ | +25 | 5 replies | |
| 4/7 | qcow2: Don't open images with header.refcount_table_clusters == 0block/ tests/ tests/ | +18 | 2 replies | |
| 5/7 | qcow2: Add iotest for an image with header.refcount_table_offset == 0tests/ tests/ | +13 | 1 reply | |
| 6/7 | qcow2: Add iotest for an empty refcount tabletests/ tests/ | +13 | 0 replies | |
| 7/7 | qcow2: Assert that the crypto header does not overlap other metadatablock/ | +1 | 1 reply |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Max Reitz | Daniel P. Berrange |
|---|---|---|
| 1/7 | R-b | |
| 2/7 | R-b | |
| 3/7 | R-b | |
| 4/7 | R-b | |
| 5/7 | R-b | |
| 6/7 | R-b | |
| 7/7 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v2 0/7] Misc qcow2 corruption checks
This series contains a few checks that prevent QEMU from crashing under some scenarios with corrupted qcow2 images.
The first patch solves the crash reported here:
https://bugs.launchpad.net/qemu/+bug/1728615
And the others solve similar crashes that I detected in the process of fixing this one.
Regards,
Berto
v2:
- Use goto fail in the l2_allocate() check [Max]
- Add check and test case for allocation of compressed clusters [Max]
- Add test case for header.refcount_table_offset == 0
- Add overlap checks to qcow2_crypto_hdr_init_func() [Max]
v1: https://lists.gnu.org/archive/html/qemu-block/2017-11/msg00010.html
- Initial version
Output of backport-diff against v1:
Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
001/7:[----] [--] 'qcow2: Prevent allocating refcount blocks at offset 0' 002/7:[0003] [FC] 'qcow2: Prevent allocating L2 tables at offset 0' 003/7:[down] 'qcow2: Prevent allocating compressed clusters at offset 0' 004/7:[----] [-C] 'qcow2: Don't open images with header.refcount_table_clusters == 0' 005/7:[down] 'qcow2: Add iotest for an image with header.refcount_table_offset == 0' 006/7:[----] [--] 'qcow2: Add iotest for an empty refcount table' 007/7:[down] 'qcow2: Assert that the crypto header does not overlap other metadata'
Alberto Garcia (7):
qcow2: Prevent allocating refcount blocks at offset 0
qcow2: Prevent allocating L2 tables at offset 0
qcow2: Prevent allocating compressed clusters at offset 0
qcow2: Don't open images with header.refcount_table_clusters == 0
qcow2: Add iotest for an image with header.refcount_table_offset == 0
qcow2: Add iotest for an empty refcount table
qcow2: Assert that the crypto header does not overlap other metadata
block/qcow2-cluster.c | 8 ++++++++ block/qcow2-refcount.c | 15 +++++++++++++- block/qcow2.c | 7 +++++++ tests/qemu-iotests/060 | 49 ++++++++++++++++++++++++++++++++++++++++++++++ tests/qemu-iotests/060.out | 39 ++++++++++++++++++++++++++++++++++++ 5 files changed, 117 insertions(+), 1 deletion(-)
Signature · 1 line
2.11.0