Skip to content

bisect: assorted leak-fixes

Martin Ågren git 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest4 patches 0 repliesNew

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4bisect: change calling-convention of `find_bisection()`bisect.c bisect.h builtin/rev-list.c+17 -140 replies
2/4bisect: fix memory leak in `find_bisection()`bisect.c+3 -10 replies
3/4bisect: fix off-by-one error in `best_bisection_sorted()`bisect.c+4 -30 replies
4/4bisect: fix memory leak when returning best elementbisect.c+5 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/4] bisect: assorted leak-fixes

This fixes a couple of leaks around find_bisection(). The first patch is new since v1 [1] to make the calling-convention of find_bisection()` less prone to misuse. Patch 2 is similar to v1, the only difference is that the "while at it" has moved into patch 1. Patches 3 and 4 are identical to v1.

Martin

[1] https://public-inbox.org/git/4795556016c25e4a78241362547c5468877f808d.1509557518.git.martin.agren@gmail.com/

Martin Ågren (4):
bisect: change calling-convention of find_bisection()
bisect: fix memory leak in find_bisection()
bisect: fix off-by-one error in best_bisection_sorted()
bisect: fix memory leak when returning best element

 bisect.h           | 12 +++++++++---
 bisect.c           | 33 +++++++++++++++++++--------------
 builtin/rev-list.c |  3 +--
 3 files changed, 29 insertions(+), 19 deletions(-)
Signature · 1 line
2.15.0.415.gac1375d7e