rs485 properties: platform agnosticism + RTS polarity
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 of 5 patches 3 repliesIn review
4 of 5 patches are in this archive. The cover letter announces 5.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 2/5 | dt-bindings: serial: Add common rs485 binding for RTS polarityDocumentation/ Documentation/ Documentation/ +1 more | +6 | 1 reply | |
| 3/5 | serial: core: Support common rs485 binding for RTS polaritydrivers/ drivers/ | +13 | 2 replies | |
| 4/5 | serial: fsl_lpuart: Support common rs485 binding for RTS polaritydrivers/ | +3 | 0 replies | |
| 5/5 | serial: imx: Support common rs485 binding for RTS polaritydrivers/ | +6 | 0 replies |
Reviews trailers per patch
1 of 4 patches has a Reviewed-by or Acked-by.
| Patch | Rob Herring |
|---|---|
| 2/5 | A-b |
| 3/5 | |
| 4/5 | |
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/5] rs485 properties: platform agnosticism + RTS polarity
Rework the common helper function for retrieving rs485 properties to be platform agnostic (patch [1/5]) and to allow specifying the RTS polarity (patch [2/5] and [3/5]).
Amend the fsl_lpuart and imx drivers to take advantage of this and fix a bunch of bugs while at it (patch [4/5] and [5/5]).
Note that Michal Oleszczyk posted a patch yesterday which documents the "rs485-rts-active-high" property supported by omap-serial in a way which suggests that *all* drivers default to active low, which is not the case (all other drivers default to active high). I think the present series is a better approach, but let's have a technical discussion about that.
I posted an earlier version of patch [1/5] a while back but withdrew it because I wanted to change uart_get_rs485_mode() to take a struct dev and a struct serial_rs485, instead of a struct uart_port (which seemed too fragile on second thought). That change has been made now.
Thanks,
Lukas
Lukas Wunner (5):
serial: Make retrieval of rs485 properties platform-agnostic
dt-bindings: serial: Add common rs485 binding for RTS polarity
serial: core: Support common rs485 binding for RTS polarity
serial: fsl_lpuart: Support common rs485 binding for RTS polarity
serial: imx: Support common rs485 binding for RTS polarity
.../devicetree/bindings/serial/fsl-imx-uart.txt | 3 ++- .../devicetree/bindings/serial/fsl-lpuart.txt | 3 ++- .../devicetree/bindings/serial/omap_serial.txt | 1 + Documentation/devicetree/bindings/serial/rs485.txt | 1 + drivers/tty/serial/atmel_serial.c | 2 +- drivers/tty/serial/fsl_lpuart.c | 15 ++++---------- drivers/tty/serial/imx.c | 11 ++++++++--- drivers/tty/serial/omap-serial.c | 11 +++++++---- drivers/tty/serial/serial_core.c | 23 +++++++++++++++------- include/linux/serial_core.h | 3 +-- 10 files changed, 43 insertions(+), 30 deletions(-)
Signature · 6 lines
2.11.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html