Skip to content

Fix throttling crashes in BlockBackend with no BlockDriverState

Alberto Garcia qemu-devel 1 version Applied

Status from this message: Thanks, applied to my block tree:

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 11 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3block: Check for inserted BlockDriverState in blk_io_limits_disable()block/block-backend.c+10 -41 reply
2/3block: Leave valid throttle timers when removing a BDS from a backendblock/block-backend.c+8 -84 replies
3/3qemu-iotests: Test I/O limits with removable mediatests/qemu-iotests/093 tests/qemu-iotests/093.out+64 -25 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchMax Reitz
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/3] Fix throttling crashes in BlockBackend with no BlockDriverState

Hi,

this series fixes the problems reported by Sochin Jiang in BlockBackend when there's a valid throttling configuration but the BDS has been removed.

The patches apply on top of Li Zhengui's "all I/O should be completed before removing throttle timers" and I tested this on top of Stefan's block branch (commit 900276cf24589596296d3d099fe609ad5c182ac9).

Regards,

Berto

Alberto Garcia (3):
block: Check for inserted BlockDriverState in blk_io_limits_disable()
block: Leave valid throttle timers when removing a BDS from a backend
qemu-iotests: Test I/O limits with removable media

 block/block-backend.c      | 30 +++++++++++++---------
 tests/qemu-iotests/093     | 62 ++++++++++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/093.out |  4 +--
 3 files changed, 82 insertions(+), 14 deletions(-)
Signature · 1 line
2.11.0