Skip to content

rds-tcp netns delete related fixes

Sowmini Varadhan netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3rds: tcp: remove redundant function rds_tcp_conn_paths_destroy()net/rds/tcp.c+1 -241 reply
2/3rds: tcp: correctly sequence cleanup on netns deletion.net/rds/connection.c net/rds/rds.h net/rds/tcp.c+7 -61 reply
3/3rds: tcp: atomically purge entries from rds_tcp_conn_list during netns deletenet/rds/tcp.c net/rds/tcp.h+8 -21 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchSantosh Shilimkar
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 0/3] rds-tcp netns delete related fixes

Patchset contains cleanup and bug fixes. Patch 1 is the removal of some redundant code/functions. Patch 2 and 3 are fixes for corner cases identified by syzkaller. I've not been able to reproduce the actual use-after-free race flagged in the syzkaller reports, thus these fixes are based on code inspection plus manual testing to make sure the modified code paths are executed without problems in the commonly encountered timing cases.

Sowmini Varadhan (3):
rds: tcp: remove redundant function rds_tcp_conn_paths_destroy()
rds: tcp: correctly sequence cleanup on netns deletion.
rds: tcp: atomically purge entries from rds_tcp_conn_list during
netns delete

 net/rds/connection.c |    3 ++-
 net/rds/rds.h        |    6 +++---
 net/rds/tcp.c        |   38 ++++++++++----------------------------
 net/rds/tcp.h        |    1 +
 4 files changed, 16 insertions(+), 32 deletions(-)