Skip to content

Improve CEC autorepeat handling

Sean Young linux-input linux-media 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3input: remove redundant check for EV_REPdrivers/input/input.c+1 -30 replies
2/3input: handle case whether first repeated key triggers repeatDocumentation/input/input.rst drivers/input/input.c+18 -30 replies
3/3media: cec: move cec autorepeat handling to rc-coredrivers/media/cec/cec-adap.c drivers/media/cec/cec-core.c drivers/media/rc/rc-main.c +1 more+14 -690 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchHans Verkuil
SeriesA-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] Improve CEC autorepeat handling

Due to the slowness of the CEC bus, autorepeat handling rather special on CEC. If the repeated user control pressed message is received, a keydown repeat should be sent immediately.

By handling this in the input layer, we can remove some ugly code from cec, which also sends a keyup event after the first keydown, to prevent autorepeat.

Sean Young (3):
input: remove redundant check for EV_REP
input: handle case whether first repeated key triggers repeat
media: cec: move cec autorepeat handling to rc-core

 Documentation/input/input.rst |  4 +++-
 drivers/input/input.c         | 21 ++++++++++++----
 drivers/media/cec/cec-adap.c  | 56 ++++---------------------------------------
 drivers/media/cec/cec-core.c  | 12 ----------
 drivers/media/rc/rc-main.c    | 10 +++++++-
 include/media/cec.h           |  5 ----
 6 files changed, 33 insertions(+), 75 deletions(-)
Signature · 1 line
2.14.3