Skip to content

remove_conflicting_framebuffers() cleanup

Michał Mirosław amd-gfx dri-devel linux-arm-kernel linux-fbdev linux-tegra virtualization 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest13 patches 8 repliesIn review
  2. v2 posting 2/20 of 12 patches 0 repliesSuperseded
  3. v2 posting 1/212 patches 7 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v19 of 13 patches32 repliesSuperseded

Changes in v3 from the cover letter

- move kerneldoc to fbdev, where functions are implemented
- split kerneldoc for remove_conflicting_framebuffers()
- propagate return value in remove_conflicting_pci_framebuffers()

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13fbdev: show fbdev number for debuggingdrivers/video/fbdev/core/fbmem.c+2 -20 replies
1/13fbdev: show fbdev number for debuggingdrivers/video/fbdev/core/fbmem.c+2 -20 replies
2/13fbdev: allow apertures == NULL in remove_conflicting_framebuffers()drivers/video/fbdev/core/fbmem.c+14 -00 replies
3/13fbdev: add kerneldoc do remove_conflicting_framebuffers()drivers/video/fbdev/core/fbmem.c+10 -01 reply
3/13fbdev: add kerneldoc do remove_conflicting_framebuffers()drivers/video/fbdev/core/fbmem.c+10 -00 replies
4/13fbdev: add remove_conflicting_pci_framebuffers()drivers/video/fbdev/core/fbmem.c include/drm/drm_fb_helper.h include/linux/fb.h+49 -01 reply
4/13fbdev: add remove_conflicting_pci_framebuffers()drivers/video/fbdev/core/fbmem.c include/drm/drm_fb_helper.h include/linux/fb.h+49 -00 replies
5/13drm/amdgpu: use simpler remove_conflicting_pci_framebuffers()drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c+1 -230 replies
5/13drm/amdgpu: use simpler remove_conflicting_pci_framebuffers()drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c+1 -230 replies
6/13drm/bochs: use simpler remove_conflicting_pci_framebuffers()drivers/gpu/drm/bochs/bochs_drv.c+1 -170 replies
7/13drm/cirrus: use simpler remove_conflicting_pci_framebuffers()drivers/gpu/drm/cirrus/cirrus_drv.c+1 -220 replies
8/13drm/mgag200: use simpler remove_conflicting_pci_framebuffers()drivers/gpu/drm/mgag200/mgag200_drv.c drivers/gpu/drm/mgag200/mgag200_main.c+1 -290 replies
8/13drm/mgag200: use simpler remove_conflicting_pci_framebuffers()drivers/gpu/drm/mgag200/mgag200_drv.c drivers/gpu/drm/mgag200/mgag200_main.c+1 -290 replies
9/13drm/radeon: use simpler remove_conflicting_pci_framebuffers()drivers/gpu/drm/radeon/radeon_drv.c+1 -220 replies
9/13drm/radeon: use simpler remove_conflicting_pci_framebuffers()drivers/gpu/drm/radeon/radeon_drv.c+1 -220 replies
10/13drm/virtio: use simpler remove_conflicting_pci_framebuffers()drivers/gpu/drm/virtio/virtgpu_drm_bus.c+3 -210 replies
10/13drm/virtio: use simpler remove_conflicting_pci_framebuffers()drivers/gpu/drm/virtio/virtgpu_drm_bus.c+3 -210 replies
11/13drm/vc4: use simpler remove_conflicting_framebuffers(NULL)drivers/gpu/drm/vc4/vc4_drv.c+1 -190 replies
11/13drm/vc4: use simpler remove_conflicting_framebuffers(NULL)drivers/gpu/drm/vc4/vc4_drv.c+1 -190 replies
12/13drm/sun4i: use simpler remove_conflicting_framebuffers(NULL)drivers/gpu/drm/sun4i/sun4i_drv.c+1 -170 replies
12/13drm/sun4i: use simpler remove_conflicting_framebuffers(NULL)drivers/gpu/drm/sun4i/sun4i_drv.c+1 -170 replies
13/13drm/tegra: kick out simplefbdrivers/gpu/drm/tegra/drm.c+4 -00 replies
13/13drm/tegra: kick out simplefbdrivers/gpu/drm/tegra/drm.c+4 -00 replies

Reviews trailers per patch

21 of 23 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBartlomiej ZolnierkiewiczDaniel VetterAlex DeucherEric AnholtMaxime RipardPaul Menzel
SeriesA-b A-b
1/13A-b A-b A-b A-b
1/13A-b A-b A-b A-b
2/13A-b
3/13A-b
3/13A-b
4/13
4/13
5/13A-b A-b A-b A-b
5/13A-b A-b A-b A-b
6/13A-b
7/13A-b
8/13A-b A-b
8/13A-b A-b
9/13A-b A-b A-b A-b
9/13A-b A-b A-b A-b
10/13A-b A-b
10/13A-b A-b
11/13A-b A-b A-b A-b
11/13A-b A-b A-b A-b
12/13A-b A-b A-b A-b
12/13A-b A-b A-b A-b
13/13A-b A-b
13/13A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/13] remove_conflicting_framebuffers() cleanup

This series cleans up duplicated code for replacing firmware FB driver with proper DRI driver and adds handover support to Tegra driver.

This is a sligtly updated version of a series sent on 24 Nov 2017.

---
v2:
- rebased on current drm-next
- dropped staging/sm750fb changes
- added kernel docs for DRM helpers
v3:
- move kerneldoc to fbdev, where functions are implemented
- split kerneldoc for remove_conflicting_framebuffers()
- propagate return value in remove_conflicting_pci_framebuffers()

---
Michał Mirosław (13):
fbdev: show fbdev number for debugging
fbdev: allow apertures == NULL in remove_conflicting_framebuffers()
fbdev: add kerneldoc do remove_conflicting_framebuffers()
fbdev: add remove_conflicting_pci_framebuffers() drm/amdgpu: use simpler remove_conflicting_pci_framebuffers() drm/bochs: use simpler remove_conflicting_pci_framebuffers() drm/cirrus: use simpler remove_conflicting_pci_framebuffers() drm/mgag200: use simpler remove_conflicting_pci_framebuffers() drm/radeon: use simpler remove_conflicting_pci_framebuffers() drm/virtio: use simpler remove_conflicting_pci_framebuffers() drm/vc4: use simpler remove_conflicting_framebuffers(NULL) drm/sun4i: use simpler remove_conflicting_framebuffers(NULL) drm/tegra: kick out simplefb

 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c  | 24 +--------
 drivers/gpu/drm/bochs/bochs_drv.c        | 18 +------
 drivers/gpu/drm/cirrus/cirrus_drv.c      | 23 +--------
 drivers/gpu/drm/mgag200/mgag200_drv.c    | 21 +-------
 drivers/gpu/drm/mgag200/mgag200_main.c   |  9 ----
 drivers/gpu/drm/radeon/radeon_drv.c      | 23 +--------
 drivers/gpu/drm/sun4i/sun4i_drv.c        | 18 +------
 drivers/gpu/drm/tegra/drm.c              |  4 ++
 drivers/gpu/drm/vc4/vc4_drv.c            | 20 +-------
 drivers/gpu/drm/virtio/virtgpu_drm_bus.c | 24 ++-------
 drivers/video/fbdev/core/fbmem.c         | 63 +++++++++++++++++++++++-
 include/drm/drm_fb_helper.h              | 12 +++++
 include/linux/fb.h                       |  2 +
 13 files changed, 89 insertions(+), 172 deletions(-)
Signature · 6 lines
2.18.0

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization