Skip to content

More transport API improvements

Jonathan Tan git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2clone, fetch: remove redundant transport checkbuiltin/clone.c builtin/fetch.c+0 -61 reply
2/2transport: make transport vtable more privatetransport-helper.c transport-internal.h transport.c +1 more+120 -871 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] More transport API improvements

Note that this is built on jt/transport-no-more-rsync.

I have found the transport mechanism relatively complicated, so here is some more effort in the hope of making it more readily understood.

Patch 1 is probably good to go in as-is.

Patch 2 is a modification of the transport API by making certain variables in the transport interface struct more private, and might need more discussion. I also discuss the possible future work that this modification makes possible.

Jonathan Tan (2):
clone, fetch: remove redundant transport check
transport: make transport vtable more private

 builtin/clone.c      |  3 ---
 builtin/fetch.c      |  3 ---
 transport-helper.c   | 23 +++++++++++-------
 transport-internal.h | 61 ++++++++++++++++++++++++++++++++++++++++++++++
 transport.c          | 69 ++++++++++++++++++++++++++++++++--------------------
 transport.h          | 54 ++--------------------------------------
 6 files changed, 120 insertions(+), 93 deletions(-)
 create mode 100644 transport-internal.h
Signature · 1 line
2.15.1.504.g5279b80103-goog