Skip to content

Change ISA_BUS_API dependency to selection

William Breathitt Gray linux-gpio linux-iio linux-watchdog lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 15 repliesIn review
  2. v13 patches 6 repliesSuperseded

Changes in v2 from the cover letter

- Remove select ISA_BUS_API line from ISA_BUS Kconfig option
- Update ISA_BUS help text to reflect updated use
- Add explicit EXPERT dependency for PC104 Kconfig option

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5iio: Change ISA_BUS_API dependency to selectiondrivers/iio/adc/Kconfig drivers/iio/counter/Kconfig drivers/iio/dac/Kconfig+6 -32 replies
2/5watchdog: Change ISA_BUS_API dependency to selectiondrivers/watchdog/Kconfig+2 -11 reply
3/5gpio: Change ISA_BUS_API dependency to selectiondrivers/gpio/Kconfig+9 -55 replies
4/5isa: Remove ISA_BUS_API selection for ISA_BUSarch/x86/Kconfig+6 -41 reply
5/5pc104: Add EXPERT dependency for PC104 Kconfig optioninit/Kconfig+1 -12 replies

Reviews trailers per patch

2 of 5 patches have a Reviewed-by or Acked-by.

PatchGuenter RoeckJonathan Cameron
1/5A-b
2/5A-b
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] Change ISA_BUS_API dependency to selection

Changes in v2:
- Remove select ISA_BUS_API line from ISA_BUS Kconfig option
- Update ISA_BUS help text to reflect updated use
- Add explicit EXPERT dependency for PC104 Kconfig option

The ISA_BUS_API Kconfig option enables the compilation of the ISA bus driver. The ISA bus driver does not perform any hardware interaction, and is instead just a thin layer of software abstraction to eliminate boilerplate code common to ISA-style device drivers. Since ISA_BUS_API has no dependencies and does not jeopardize the integrity of the system when enabled, drivers should select it when the ISA bus driver functionality is needed.

Originally, when the ISA_BUS_API Kconfig option was introduced, it served a dual-purpose of masking drivers ISA-style devices not commonly found for desktop systems, such as the PC/104 device drivers. This secondary semantic was inappropriate for the ISA_BUS_API option, and proper masking of these device drivers is now accomplished via dedicated Kconfig options such as CONFIG_PC104.

Linus, please pickup this entire patchset through your GPIO subsystem tree; a recursive dependency error is present if these patches are cherry-picked (see https://lkml.org/lkml/2017/12/26/235), so they should be merged together in the same tree.

Maciej, this patchset resolves the recursive dependency issue you encountered, so now you should be able to submit your Winbond GPIO driver with the ISA_BUS_API selection as desired.

William Breathitt Gray (5):
iio: Change ISA_BUS_API dependency to selection
watchdog: Change ISA_BUS_API dependency to selection
gpio: Change ISA_BUS_API dependency to selection
isa: Remove ISA_BUS_API selection for ISA_BUS
pc104: Add EXPERT dependency for PC104 Kconfig option

 arch/x86/Kconfig            | 10 ++++++----
 drivers/gpio/Kconfig        | 14 +++++++++-----
 drivers/iio/adc/Kconfig     |  3 ++-
 drivers/iio/counter/Kconfig |  3 ++-
 drivers/iio/dac/Kconfig     |  3 ++-
 drivers/watchdog/Kconfig    |  3 ++-
 init/Kconfig                |  2 +-
 7 files changed, 24 insertions(+), 14 deletions(-)
Signature · 1 line
2.15.1