Skip to content

TUN fixes

Simon Ruderich wireguard 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7tun: TUNDevice: document behavior of offset parametersrc/tun.go+2 -20 replies
2/7tun_linux: add PIHeaderSize constant instead of magic valuesrc/tun_linux.go+5 -40 replies
3/7tun_linux: document packet information header valuessrc/tun_linux.go+2 -00 replies
4/7helper_test: reorder DummyTUN functions to follow interface ordersrc/helper_test.go+12 -120 replies
5/7helper_test: adapt to TUNDevice interface changesrc/helper_test.go+4 -40 replies
6/7tun_darwin: adapt to TUNDevice interface changesrc/tun_darwin.go+10 -30 replies
7/7tun_darwin: adapt to TUNDevice interface changesrc/tun_windows.go+6 -23 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] TUN fixes

Hello,

While looking through the latest commits I noticed that 996c7c4 ("Removed IFF_NO_PI from TUN linux", 2017-12-04) broke the test suite and darwin and windows builds by changing the TUNDevice interface. This patch series adds documentation and tries to fix the tests and the darwin/windows tun (however that part is untested as I don't have access to these systems and it looks like the build is already broken for a while).

Note that d73f960 ("Peer timer teardown", 2017-12-29) broke the tests in a separate way so even with these patches the test suite will not pass.

Regards
Simon

Simon Ruderich (7):
tun: TUNDevice: document behavior of offset parameter
tun_linux: add PIHeaderSize constant instead of magic value
tun_linux: document packet information header values
helper_test: reorder DummyTUN functions to follow interface order
helper_test: adapt to TUNDevice interface change
tun_darwin: adapt to TUNDevice interface change
tun_darwin: adapt to TUNDevice interface change

 src/helper_test.go | 26 +++++++++++++-------------
 src/tun.go         |  4 ++--
 src/tun_darwin.go  | 13 ++++++++++---
 src/tun_linux.go   | 11 +++++++----
 src/tun_windows.go |  8 ++++++--
 5 files changed, 38 insertions(+), 24 deletions(-)
Signature · 1 line
2.15.1