Fix EVP_PKEY key types handling
Get series with b4
b4 am [email protected]...Versions newest first
- v1 Latest3 patches 6 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | OpenSSL: check EVP_PKEY key types before returning the pkeysrc/ | +3 | 2 replies | |
| 2/3 | OpenSSL: remove some EVP_PKEY type checkssrc/ | +17 | 18 replies | |
| 3/3 | OpenSSL: remove EVP_PKEY_id()configure.ac src/ | +0 | 1 reply |
Reviews trailers per patch
2 of 3 patches have a Reviewed-by or Acked-by.
| Patch | Steffan Karger |
|---|---|
| 1/3 | A-b |
| 2/3 | |
| 3/3 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Openvpn-devel] [PATCH 0/3] Fix EVP_PKEY key types handling
Hello,
The dubious commiter of the OpenSSL 1.1 changes got it wrong again. Not sure if I can trust this guy. Not to mention that he pretends to be /me/... :)
Anyway, I fixed some of his mistakes again.
For reference, this fixes a bug reported by Selva (hence the Reported-By tag on the first patch) where openvpn crashes when it's feeded with an ECC key (same bug shall arise when using a DSA key).
The first patch in the series is necessary (it's the one that fixes the bugs). Patch 2 remove code that is no longer necessary. Patch 3 then remove an entire function which is no longer used (although I'd understand if one wants to keep this function around).
Hopefully, this is the last time I have to correct a bug by the previous commiter (I will not name him. That would sound too weird). Next time, he'll have to do it by himself :)
Best regards,
-- Emmanuel Deloget
Emmanuel Deloget (3):
OpenSSL: check EVP_PKEY key types before returning the pkey
OpenSSL: remove some EVP_PKEY type checks
OpenSSL: remove EVP_PKEY_id()
configure.ac | 1 - src/openvpn/openssl_compat.h | 20 +++----------------- src/openvpn/ssl_openssl.c | 33 +++++++++++++++++---------------- 3 files changed, 20 insertions(+), 34 deletions(-)
Signature · 1 line
2.11.0