Skip to content

Cookie redaction during GIT_TRACE_CURL

Jonathan Tan git 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 0 repliesNew
  2. v1 RFC2 patches 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2http: support cookie redaction when tracingDocumentation/git.txt http.c t/t5551-http-fetch-smart.sh+82 -00 replies
2/2http: support omitting data from tracesDocumentation/git.txt http.c t/t5551-http-fetch-smart.sh+35 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] Cookie redaction during GIT_TRACE_CURL

Thanks, Eric. Changes in v2:
- documented all environment variables introduced
- made test more clear by ensuring that no cookie keys are suffixes or prefixes of others
- tested empty value

As far as I can tell, it does not seem possible that Git generates a cookie with no equals sign (like "Secure" or "HttpOnly" described in RFC 6265). When I try to craft a cookie file containing that (using "Set-Cookie: Foo=; HttpOnly", for example), the no-equals-sign cookie just disappears.

Jonathan Tan (2):
http: support cookie redaction when tracing
http: support omitting data from traces

 Documentation/git.txt       | 10 ++++++
 http.c                      | 82 ++++++++++++++++++++++++++++++++++++++++-----
 t/t5551-http-fetch-smart.sh | 33 ++++++++++++++++++
 3 files changed, 117 insertions(+), 8 deletions(-)
Signature · 1 line
2.16.0.rc2.37.ge0d575025.dirty

Read the cover letter in its thread