RDS: zerocopy support
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest7 patches 10 repliesIn review
- v27 patches 23 repliesSuperseded
- v17 patches 15 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | skbuff: export mm_[un]account_pinned_pages for other modulesinclude/ net/ | +7 | 1 reply | |
| 2/7 | rds: hold a sock ref from rds_message to the rds_socknet/ net/ | +8 | 1 reply | |
| 3/7 | sock: permit SO_ZEROCOPY on PF_RDS socketnet/ | +14 | 1 reply | |
| 4/7 | rds: support for zcopy completion notificationinclude/ net/ net/ +2 more | +96 | 2 replies | |
| 5/7 | rds: zerocopy Tx support.include/ net/ net/ +1 more | +91 | 2 replies | |
| 6/7 | selftests/net: add support for PF_RDS socketstools/ | +64 | 1 reply | |
| 7/7 | selftests/net: add zerocopy support for PF_RDS test casetools/ | +64 | 1 reply |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Santosh Shilimkar | Willem de Bruijn |
|---|---|---|
| 1/7 | A-b | |
| 2/7 | A-b | |
| 3/7 | A-b | |
| 4/7 | A-b | A-b |
| 5/7 | A-b | A-b |
| 6/7 | A-b | |
| 7/7 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 net-next 0/7] RDS: zerocopy support
This is version 3 of the series, following up on review comments for
http://patchwork.ozlabs.org/project/netdev/list/?series=28530
Review comments addressed
Patch 4
- fix fragile use of skb->cb[], do not set ee_code incorrectly.
Patch 5:
- remove needless bzero of skb->cb[], consolidate err cleanup
A brief overview of this feature follows.
This patch series provides support for MSG_ZERCOCOPY on a PF_RDS socket based on the APIs and infrastructure added by Commit f214f915e7db ("tcp: enable MSG_ZEROCOPY")
For single threaded rds-stress testing using rds-tcp with the ixgbe driver using 1M message sizes (-a 1M -q 1M) preliminary results show that there is a significant reduction in latency: about 90 usec with zerocopy, compared with 200 usec without zerocopy.
This patchset modifies the above for zerocopy in the following manner.
- if the MSG_ZEROCOPY flag is specified with rds_sendmsg(), and,
- if the SO_ZEROCOPY socket option has been set on the PF_RDS socket, application pages sent down with rds_sendmsg are pinned. The pinning uses the accounting infrastructure added by a91dbff551a6 ("sock: ulimit on MSG_ZEROCOPY pages"). The message is unpinned when all references to the message go down to 0, and the message is freed by rds_message_purge.
A multithreaded application using this infrastructure must send down a unique 32 bit cookie as ancillary data with each sendmsg invocation. The format of this ancillary data is described in Patch 5 of the series. The cookie is passed up to the application on the sk_error_queue when the message is unpinned, indicating to the application that it is now safe to free/reuse the message buffer. The details of the completion notification are provided in Patch 4 of this series.
Sowmini Varadhan (7):
skbuff: export mm_[un]account_pinned_pages for other modules
rds: hold a sock ref from rds_message to the rds_sock
sock: permit SO_ZEROCOPY on PF_RDS socket
rds: support for zcopy completion notification
rds: zerocopy Tx support.
selftests/net: add support for PF_RDS sockets selftests/net: add zerocopy support for PF_RDS test case
include/linux/skbuff.h | 3 + include/uapi/linux/errqueue.h | 2 + include/uapi/linux/rds.h | 1 + net/core/skbuff.c | 6 +- net/core/sock.c | 25 +++--- net/rds/af_rds.c | 2 + net/rds/message.c | 132 ++++++++++++++++++++++++++- net/rds/rds.h | 17 ++++- net/rds/recv.c | 2 + net/rds/send.c | 51 ++++++++--- tools/testing/selftests/net/msg_zerocopy.c | 133 ++++++++++++++++++++++++++- 11 files changed, 339 insertions(+), 35 deletions(-)