Skip to content

RDS: zerocopy support

Sowmini Varadhan netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 10 repliesIn review
  2. v27 patches 23 repliesSuperseded
  3. v17 patches 15 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7skbuff: export mm_[un]account_pinned_pages for other modulesinclude/linux/skbuff.h net/core/skbuff.c+7 -21 reply
2/7rds: hold a sock ref from rds_message to the rds_socknet/rds/message.c net/rds/send.c+8 -71 reply
3/7sock: permit SO_ZEROCOPY on PF_RDS socketnet/core/sock.c+14 -111 reply
4/7rds: support for zcopy completion notificationinclude/uapi/linux/errqueue.h net/rds/af_rds.c net/rds/message.c +2 more+96 -72 replies
5/7rds: zerocopy Tx support.include/uapi/linux/rds.h net/rds/message.c net/rds/rds.h +1 more+91 -82 replies
6/7selftests/net: add support for PF_RDS socketstools/testing/selftests/net/msg_zerocopy.c+64 -11 reply
7/7selftests/net: add zerocopy support for PF_RDS test casetools/testing/selftests/net/msg_zerocopy.c+64 -41 reply

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchSantosh ShilimkarWillem de Bruijn
1/7A-b
2/7A-b
3/7A-b
4/7A-b A-b
5/7A-b A-b
6/7A-b
7/7A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 net-next 0/7] RDS: zerocopy support

This is version 3 of the series, following up on review comments for
http://patchwork.ozlabs.org/project/netdev/list/?series=28530

Review comments addressed
Patch 4
- fix fragile use of skb->cb[], do not set ee_code incorrectly.
Patch 5:
- remove needless bzero of skb->cb[], consolidate err cleanup

A brief overview of this feature follows.

This patch series provides support for MSG_ZERCOCOPY on a PF_RDS socket based on the APIs and infrastructure added by Commit f214f915e7db ("tcp: enable MSG_ZEROCOPY")

For single threaded rds-stress testing using rds-tcp with the ixgbe driver using 1M message sizes (-a 1M -q 1M) preliminary results show that there is a significant reduction in latency: about 90 usec with zerocopy, compared with 200 usec without zerocopy.

This patchset modifies the above for zerocopy in the following manner.
- if the MSG_ZEROCOPY flag is specified with rds_sendmsg(), and,
- if the SO_ZEROCOPY socket option has been set on the PF_RDS socket, application pages sent down with rds_sendmsg are pinned. The pinning uses the accounting infrastructure added by a91dbff551a6 ("sock: ulimit on MSG_ZEROCOPY pages"). The message is unpinned when all references to the message go down to 0, and the message is freed by rds_message_purge.

A multithreaded application using this infrastructure must send down a unique 32 bit cookie as ancillary data with each sendmsg invocation. The format of this ancillary data is described in Patch 5 of the series. The cookie is passed up to the application on the sk_error_queue when the message is unpinned, indicating to the application that it is now safe to free/reuse the message buffer. The details of the completion notification are provided in Patch 4 of this series.

Sowmini Varadhan (7):
skbuff: export mm_[un]account_pinned_pages for other modules
rds: hold a sock ref from rds_message to the rds_sock
sock: permit SO_ZEROCOPY on PF_RDS socket
rds: support for zcopy completion notification
rds: zerocopy Tx support.
selftests/net: add support for PF_RDS sockets selftests/net: add zerocopy support for PF_RDS test case

 include/linux/skbuff.h                     |    3 +
 include/uapi/linux/errqueue.h              |    2 +
 include/uapi/linux/rds.h                   |    1 +
 net/core/skbuff.c                          |    6 +-
 net/core/sock.c                            |   25 +++---
 net/rds/af_rds.c                           |    2 +
 net/rds/message.c                          |  132 ++++++++++++++++++++++++++-
 net/rds/rds.h                              |   17 ++++-
 net/rds/recv.c                             |    2 +
 net/rds/send.c                             |   51 ++++++++---
 tools/testing/selftests/net/msg_zerocopy.c |  133 ++++++++++++++++++++++++++-
 11 files changed, 339 insertions(+), 35 deletions(-)