Skip to content

A bunch of object_id conversions

Patryk Obara git 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v4 Latest12 patches 0 repliesNew

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12sha1_file: convert pretend_sha1_file to object_idDocumentation/technical/api-object-access.txt blame.c cache.h +1 more+11 -80 replies
2/12dir: convert struct sha1_stat to use object_idcache.h dir.c dir.h +1 more+58 -640 replies
3/12sha1_file: convert hash_sha1_file to object_idapply.c builtin/index-pack.c builtin/replace.c +8 more+36 -350 replies
4/12cache: clear whole hash buffer with oidclrcache.h+1 -10 replies
5/12match-trees: convert splice_tree to object_idmatch-trees.c+22 -240 replies
6/12commit: convert commit_tree* to object_idbuiltin/am.c builtin/commit-tree.c builtin/commit.c +7 more+36 -340 replies
7/12notes: convert combine_notes_* to object_idnotes.c notes.h+38 -330 replies
8/12notes: convert write_notes_tree to object_idnotes-cache.c notes-utils.c notes.c +1 more+13 -110 replies
9/12sha1_file: convert write_sha1_file to object_idapply.c builtin/checkout.c builtin/mktag.c +15 more+65 -580 replies
10/12sha1_file: convert force_object_loose to object_idbuiltin/pack-objects.c cache.h sha1_file.c+8 -70 replies
11/12sha1_file: convert write_loose_object to object_idsha1_file.c+16 -120 replies
12/12sha1_file: rename hash_sha1_file_literallybuiltin/hash-object.c cache.h sha1_file.c+8 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 00/12] A bunch of object_id conversions

Thank you, everyone, for review and thanks, Junio for queueing two first patches - I removed them from v4, as there were no more comments to them anyway.

Compared to v3:

Patch 2 (formerly 4)
- renamed all parameter names sha1_stat to oid_stat
- renamed static function load sha1_stat to load_oid_stat
- adjusted a comment, that included "sha1_stat" in text

Patch 11 (formerly 13)
- fixed a typo in the commit message

Hopefully, this will be the last iteration on this batch of object_id conversions; I already have next batch prepared (I just need to clean it up before sending).

Patryk Obara (12):
sha1_file: convert pretend_sha1_file to object_id
dir: convert struct sha1_stat to use object_id
sha1_file: convert hash_sha1_file to object_id
cache: clear whole hash buffer with oidclr
match-trees: convert splice_tree to object_id
commit: convert commit_tree* to object_id
notes: convert combine_notes_* to object_id
notes: convert write_notes_tree to object_id
sha1_file: convert write_sha1_file to object_id
sha1_file: convert force_object_loose to object_id
sha1_file: convert write_loose_object to object_id
sha1_file: rename hash_sha1_file_literally

 Documentation/technical/api-object-access.txt |   2 +-
 apply.c                                       |  12 +--
 blame.c                                       |   2 +-
 builtin/am.c                                  |   4 +-
 builtin/checkout.c                            |   3 +-
 builtin/commit-tree.c                         |   4 +-
 builtin/commit.c                              |   5 +-
 builtin/hash-object.c                         |   3 +-
 builtin/index-pack.c                          |   5 +-
 builtin/merge.c                               |   8 +-
 builtin/mktag.c                               |   6 +-
 builtin/mktree.c                              |  10 +--
 builtin/notes.c                               |   8 +-
 builtin/pack-objects.c                        |   2 +-
 builtin/receive-pack.c                        |  11 +--
 builtin/replace.c                             |   4 +-
 builtin/tag.c                                 |   2 +-
 builtin/unpack-objects.c                      |  11 ++-
 cache-tree.c                                  |  16 ++--
 cache.h                                       |  25 +++++--
 commit.c                                      |  15 ++--
 commit.h                                      |  11 +--
 convert.c                                     |   6 +-
 diffcore-rename.c                             |   4 +-
 dir.c                                         | 104 +++++++++++++-------------
 dir.h                                         |  12 +--
 log-tree.c                                    |   2 +-
 match-trees.c                                 |  46 ++++++------
 merge-recursive.c                             |   5 +-
 notes-cache.c                                 |   8 +-
 notes-merge.c                                 |   9 +--
 notes-utils.c                                 |   9 ++-
 notes-utils.h                                 |   3 +-
 notes.c                                       |  63 ++++++++--------
 notes.h                                       |  29 ++++---
 read-cache.c                                  |   6 +-
 sha1_file.c                                   | 100 +++++++++++++------------
 t/helper/test-dump-untracked-cache.c          |   4 +-
 38 files changed, 300 insertions(+), 279 deletions(-)

base-commit: 5be1f00a9a701532232f57958efab4be8c959a29

Signature · 1 line
2.14.3