Skip to content

Refactor hash search with fanout table

Jonathan Tan git 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 3 repliesIn review
  2. v12 patches 4 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2packfile: remove GIT_DEBUG_LOOKUP log statementspackfile.c+0 -110 replies
2/2packfile: refactor hash search with fanout tablepackfile.c sha1-lookup.c sha1-lookup.h+54 -140 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDerrick Stolee
SeriesR-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] Refactor hash search with fanout table

Updates from v1:
- use uint32_t so that we can operate on packfiles of up to 4G objects (this also means that I had to change the signature of the function)
- don't hide types

Derrick: you'll need to slightly change your patch to use the new API. As for find_abbrev_len_for_pack(), that's a good idea - I didn't do it in this set but it definitely should be done.

Jonathan Tan (2):
packfile: remove GIT_DEBUG_LOOKUP log statements
packfile: refactor hash search with fanout table

 packfile.c    | 29 ++++-------------------------
 sha1-lookup.c | 28 ++++++++++++++++++++++++++++
 sha1-lookup.h | 22 ++++++++++++++++++++++
 3 files changed, 54 insertions(+), 25 deletions(-)
Signature · 1 line
2.16.0.rc1.238.g530d649a79-goog