Skip to content

RFC Allow checking and repairing corrupted internal snapshots

Alberto Garcia qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2qcow2: Allow checking and repairing corrupted internal snapshotsblock/qcow2-snapshot.c block/qcow2.c block/qcow2.h+61 -12 replies
2/2qcow2: Check the L1 table parameters from all internal snapshotsblock/qcow2-snapshot.c block/qcow2.c block/qcow2.h +2 more+70 -100 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [RFC PATCH 0/2] Allow checking and repairing corrupted internal snapshots

Here's a small series that prevents the user from opening corrupted internal snapshots and allows 'qemu-img check' to detect and repair them.

This is an RFC because I tried a few different approaches to deal with this but I'm not 100% convinced with any of them.

What this one does is simply delete the corrupted snapshots when 'qemu-img check' is run with '-r all'.

Other possible alternatives:

- Do the same but with a different option ('-r snapshots' or whatever)
- Zero the L1 size field of the corrupted snapshots (so they're empty in practice) but leave them in the snapshot table, so the user would have to delete them manually afterwards.
- Ask interactively "Do you want to delete this snapshot?" for each one of them. This was mentioned in the mailing list, but is this really useful?

Berto

Alberto Garcia (2):
qcow2: Allow checking and repairing corrupted internal snapshots
qcow2: Check the L1 table parameters from all internal snapshots

 block/qcow2-snapshot.c     | 71 ++++++++++++++++++++++++++++++++++++++++++----
 block/qcow2.c              |  9 ++++--
 block/qcow2.h              |  4 ++-
 tests/qemu-iotests/080     | 16 ++++++++++-
 tests/qemu-iotests/080.out | 42 +++++++++++++++++++++++++--
 5 files changed, 131 insertions(+), 11 deletions(-)
Signature · 1 line
2.11.0