drm/panel: Add device link in drm_panel_attach()
Status from this message: Applied both of these to drm-misc-next, thanks.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest2 patches 26 repliesApplied
- v32 patches 1 replySuperseded
- v22 patches 8 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 2 patches | 3 replies | Superseded |
Changes in v4 from the cover letter
- "drm/panel: Remove drm_panel_detach() calls from all panel drives"
- Update kerneldoc for drm_panel_detach() and drm_panel_attach() according to Daniel Vetter's suugestion and add his reviewed-by.
- "drm/panel: Add device_link from panel device to drm device"
- none
Patches in v4 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | drm/panel: Remove drm_panel_detach() calls from all panel drivesdrivers/ drivers/ drivers/ +7 more | +6 | 0 replies | |
| 2/2 | drm/panel: Add device_link from panel device to drm devicedrivers/ include/ | +11 | 24 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Daniel Vetter | Eric Anholt |
|---|---|---|
| 1/2 | R-b | |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/2] drm/panel: Add device link in drm_panel_attach()
I guess the first patch should be mergable. With the second, maybe it is better to wait until we have a full solution including the bridges too. What should I do to get the first patch merged?
The third version of these patches can be found here:
https://lists.freedesktop.org/archives/dri-devel/2018-April/174221.html
Changes since v3:
- "drm/panel: Remove drm_panel_detach() calls from all panel drives"
- Update kerneldoc for drm_panel_detach() and drm_panel_attach() according to Daniel Vetter's suugestion and add his reviewed-by.
- "drm/panel: Add device_link from panel device to drm device"
- none
The first patch could be squashed to second, but kept is separate since I think it is correct even without the second patch.
With these patches unbinding a panel driver in use does not cause nasty backtraces and corrupted drm core structures, but instead it cleanly unbinds the drm master device at the same time.
The only down side (currently[1]) is that the drm device does not reprobe if the panel driver is bound again, but everything should work if the drm master driver is bound manually.
Best regards,
Jyri
Jyri Sarha (2):
drm/panel: Remove drm_panel_detach() calls from all panel drives drm/panel: Add device_link from panel device to drm device
drivers/gpu/drm/drm_panel.c | 16 ++++++++++++++++ drivers/gpu/drm/panel/panel-innolux-p079zca.c | 1 - drivers/gpu/drm/panel/panel-jdi-lt070me05000.c | 1 - drivers/gpu/drm/panel/panel-lvds.c | 1 - drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c | 1 - drivers/gpu/drm/panel/panel-seiko-43wvf1g.c | 1 - drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c | 1 - drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c | 1 - drivers/gpu/drm/panel/panel-simple.c | 1 - drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 1 - include/drm/drm_panel.h | 1 + 11 files changed, 17 insertions(+), 9 deletions(-)
Signature · 6 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel