Skip to content

RDS: optimized notification for zerocopy completion

Sowmini Varadhan netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest posting 2/23 patches 1 replyIn review
  2. v3 posting 1/23 patches 5 repliesSuperseded
  3. v23 patches 4 repliesSuperseded

Patches in v3 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3selftests/net: revert the zerocopy Rx path for PF_RDStools/testing/selftests/net/msg_zerocopy.c+0 -670 replies
2/3rds: deliver zerocopy completion notification with datainclude/uapi/linux/errqueue.h include/uapi/linux/rds.h net/rds/af_rds.c +3 more+60 -270 replies
3/3selftests/net: reap zerocopy completions passed up as ancillary data.tools/testing/selftests/net/msg_zerocopy.c+57 -80 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchWillem de BruijnSantosh Shilimkar
1/3A-b A-b
2/3A-b A-b
3/3A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH RESEND V3 net-next 0/3] RDS: optimized notification for zerocopy completion

Resending with acked-by additions: previous attempt does not show up in Patchwork. This time with a new mail Message-Id.

RDS applications use predominantly request-response, transacation based IPC, so that ingress and egress traffic are well-balanced, and it is possible/desirable to reduce system-call overhead by piggybacking the notifications for zerocopy completion response with data.

Moreover, it has been pointed out that socket functions block if sk_err is non-zero, thus if the RDS code does not plan/need to use sk_error_queue path for completion notification, it is preferable to remove the sk_errror_queue related paths in RDS.

Both of these goals are implemented in this series.

v2: removed sk_error_queue support
v3: incorporated additional code review comments (details in each patch)

Sowmini Varadhan (3):
selftests/net: revert the zerocopy Rx path for PF_RDS
rds: deliver zerocopy completion notification with data selftests/net: reap zerocopy completions passed up as ancillary data.

 include/uapi/linux/errqueue.h              |    2 -
 include/uapi/linux/rds.h                   |    7 ++
 net/rds/af_rds.c                           |    7 +-
 net/rds/message.c                          |   38 ++++-----
 net/rds/rds.h                              |    2 +
 net/rds/recv.c                             |   31 +++++++-
 tools/testing/selftests/net/msg_zerocopy.c |  120 ++++++++++++----------------
 7 files changed, 111 insertions(+), 96 deletions(-)