Skip to content

net/mlx5: clean driver

Nelio Laranjeiro dpdk-dev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest10 patches 2 repliesIn review
  2. v210 patches 0 repliesSuperseded

Changes in v2 from the cover letter

- fix a segfault in Tx queue release.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10net/mlx5: fix sriov flagdrivers/net/mlx5/mlx5.c drivers/net/mlx5/mlx5.h drivers/net/mlx5/mlx5_ethdev.c+2 -550 replies
2/10net/mlx5: name parameters in function prototypesdrivers/net/mlx5/mlx5.h drivers/net/mlx5/mlx5_rxtx.h+195 -1580 replies
3/10net/mlx5: mark parameters with unused attributedrivers/net/mlx5/mlx5.c drivers/net/mlx5/mlx5_ethdev.c drivers/net/mlx5/mlx5_flow.c +7 more+55 -850 replies
4/10net/mlx5: normalize function prototypesdrivers/net/mlx5/mlx5_flow.c drivers/net/mlx5/mlx5_mr.c drivers/net/mlx5/mlx5_rxq.c +1 more+19 -180 replies
5/10net/mlx5: add missing function documentationdrivers/net/mlx5/mlx5_ethdev.c drivers/net/mlx5/mlx5_mr.c drivers/net/mlx5/mlx5_rxq.c +2 more+71 -140 replies
6/10net/mlx5: remove useless empty linesdrivers/net/mlx5/mlx5.c drivers/net/mlx5/mlx5_ethdev.c drivers/net/mlx5/mlx5_mr.c +3 more+0 -390 replies
7/10net/mlx5: remove control path locksdrivers/net/mlx5/mlx5.c drivers/net/mlx5/mlx5.h drivers/net/mlx5/mlx5_ethdev.c +8 more+9 -1660 replies
8/10net/mlx5: prefix all function with mlx5drivers/net/mlx5/mlx5.c drivers/net/mlx5/mlx5.h drivers/net/mlx5/mlx5_ethdev.c +13 more+868 -10690 replies
9/10net/mlx5: change non failing function return valuesdrivers/net/mlx5/mlx5.h drivers/net/mlx5/mlx5_mr.c drivers/net/mlx5/mlx5_rxq.c +3 more+22 -400 replies
10/10net/mlx5: standardize on negative errno valuesdrivers/net/mlx5/mlx5.c drivers/net/mlx5/mlx5_ethdev.c drivers/net/mlx5/mlx5_flow.c +10 more+719 -4870 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchAdrien Mazarguil
1/10A-b
2/10A-b
3/10A-b
4/10A-b
5/10A-b
6/10A-b
7/10A-b
8/10A-b
9/10A-b
10/10A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/10] net/mlx5: clean driver

- Removes unused SR-IOV flag.
- Adds missing documentation on some functions.
- Removes the spin-lock on the private structure.
- Standardize the return values of all functions as discussed on the mailing list [1].

[1] https://dpdk.org/ml/archives/dev/2018-January/087991.html

Changes in v2:

- fix a segfault in Tx queue release.

Nelio Laranjeiro (10):
net/mlx5: fix sriov flag
net/mlx5: name parameters in function prototypes net/mlx5: mark parameters with unused attribute net/mlx5: normalize function prototypes net/mlx5: add missing function documentation net/mlx5: remove useless empty lines net/mlx5: remove control path locks net/mlx5: prefix all function with mlx5 net/mlx5: change non failing function return values net/mlx5: standardize on negative errno values

 drivers/net/mlx5/mlx5.c          | 236 ++++++--------
 drivers/net/mlx5/mlx5.h          | 240 ++++++--------
 drivers/net/mlx5/mlx5_ethdev.c   | 611 +++++++++++++++--------------------
 drivers/net/mlx5/mlx5_flow.c     | 664 ++++++++++++++++++++-------------------
 drivers/net/mlx5/mlx5_mac.c      |  42 ++-
 drivers/net/mlx5/mlx5_mr.c       | 130 ++++----
 drivers/net/mlx5/mlx5_rss.c      | 159 ++++------
 drivers/net/mlx5/mlx5_rxmode.c   |  28 +-
 drivers/net/mlx5/mlx5_rxq.c      | 488 ++++++++++++++--------------
 drivers/net/mlx5/mlx5_rxtx.c     |  49 ++-
 drivers/net/mlx5/mlx5_rxtx.h     | 161 +++++-----
 drivers/net/mlx5/mlx5_rxtx_vec.c |  25 +-
 drivers/net/mlx5/mlx5_socket.c   | 115 ++++---
 drivers/net/mlx5/mlx5_stats.c    | 189 +++++------
 drivers/net/mlx5/mlx5_trigger.c  | 234 +++++++-------
 drivers/net/mlx5/mlx5_txq.c      | 229 +++++++-------
 drivers/net/mlx5/mlx5_vlan.c     |  93 ++----
 17 files changed, 1761 insertions(+), 1932 deletions(-)
Signature · 1 line
2.11.0