Skip to content

EEH refactoring 1

Sam Bobroff linuxppc-dev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 10 repliesIn review
  2. v19 patches 13 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9powerpc/eeh: Remove eeh_handle_event()arch/powerpc/include/asm/eeh_event.h arch/powerpc/kernel/eeh_driver.c arch/powerpc/kernel/eeh_event.c+19 -302 replies
2/9powerpc/eeh: Manage EEH_PE_RECOVERING inside eeh_handle_normal_event()arch/powerpc/include/asm/eeh_event.h arch/powerpc/kernel/eeh_driver.c arch/powerpc/kernel/eeh_event.c+12 -211 reply
3/9powerpc/eeh: Fix misleading comment in __eeh_addr_cache_get_device()arch/powerpc/kernel/eeh_cache.c+1 -21 reply
4/9powerpc/eeh: Remove misleading test in eeh_handle_normal_event()arch/powerpc/kernel/eeh_driver.c+11 -131 reply
5/9powerpc/eeh: Rename frozen_bus to bus in eeh_handle_normal_event()arch/powerpc/kernel/eeh_driver.c+5 -51 reply
6/9powerpc/eeh: Clarify arguments to eeh_reset_device()arch/powerpc/kernel/eeh_driver.c+11 -91 reply
7/9powerpc/eeh: Remove always-true tests in eeh_reset_device()arch/powerpc/kernel/eeh_driver.c+2 -21 reply
8/9powerpc/eeh: Factor out common code eeh_reset_device()arch/powerpc/kernel/eeh_driver.c+10 -222 replies
9/9powerpc/eeh: Add eeh_state_active() helperarch/powerpc/include/asm/eeh.h arch/powerpc/kernel/eeh.c arch/powerpc/platforms/powernv/eeh-powernv.c+14 -201 reply

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAlexey Kardashevskiy
SeriesR-b
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/9] EEH refactoring 1

Hello everyone,

Here is a set of some small, mostly idempotent, changes to improve maintainability in some of the EEH code, primarily in eeh_driver.c.

I've kept them all small to aid review but perhaps they should be squashed down before being applied.

Cheers,
Sam.

Patch set changelog follows:

====== v1 -> v2: ======

Patch 1/9: powerpc/eeh: Remove eeh_handle_event()

Patch 2/9: powerpc/eeh: Manage EEH_PE_RECOVERING inside eeh_handle_normal_event()

Patch 3/9: powerpc/eeh: Fix misleading comment in __eeh_addr_cache_get_device()

Patch 4/9: powerpc/eeh: Remove misleading test in eeh_handle_normal_event()

Patch 5/9: powerpc/eeh: Rename frozen_bus to bus in eeh_handle_normal_event()

Patch 6/9: powerpc/eeh: Clarify arguments to eeh_reset_device()
* Re-ordered parameters to eeh_reset_device() to keep pe first.
* Changed eeh_aware_driver to driver_eeh_aware.

Patch 7/9: powerpc/eeh: Remove always-true tests in eeh_reset_device()

Patch 8/9: powerpc/eeh: Factor out common code eeh_reset_device()
* In one case, added braces to "if" to match "else".

Patch 9/9: powerpc/eeh: Add eeh_state_active() helper

====== v1: ======

Patch 1/9: powerpc/eeh: Remove eeh_handle_event()
Patch 2/9: powerpc/eeh: Manage EEH_PE_RECOVERING inside eeh_handle_normal_event() Patch 3/9: powerpc/eeh: Fix misleading comment in __eeh_addr_cache_get_device() Patch 4/9: powerpc/eeh: Remove misleading test in eeh_handle_normal_event() Patch 5/9: powerpc/eeh: Rename frozen_bus to bus in eeh_handle_normal_event() Patch 6/9: powerpc/eeh: Clarify arguments to eeh_reset_device() Patch 7/9: powerpc/eeh: Remove always-true tests in eeh_reset_device() Patch 8/9: powerpc/eeh: Factor out common code eeh_reset_device() Patch 9/9: powerpc/eeh: Add eeh_state_active() helper

Sam Bobroff (9):
powerpc/eeh: Remove eeh_handle_event()
powerpc/eeh: Manage EEH_PE_RECOVERING inside eeh_handle_normal_event() powerpc/eeh: Fix misleading comment in __eeh_addr_cache_get_device() powerpc/eeh: Remove misleading test in eeh_handle_normal_event() powerpc/eeh: Rename frozen_bus to bus in eeh_handle_normal_event() powerpc/eeh: Clarify arguments to eeh_reset_device() powerpc/eeh: Remove always-true tests in eeh_reset_device() powerpc/eeh: Factor out common code eeh_reset_device() powerpc/eeh: Add eeh_state_active() helper

 arch/powerpc/include/asm/eeh.h               |   6 ++
 arch/powerpc/include/asm/eeh_event.h         |   3 +-
 arch/powerpc/kernel/eeh.c                    |  19 ++--
 arch/powerpc/kernel/eeh_cache.c              |   3 +-
 arch/powerpc/kernel/eeh_driver.c             | 137 +++++++++++----------------
 arch/powerpc/kernel/eeh_event.c              |   6 +-
 arch/powerpc/platforms/powernv/eeh-powernv.c |   9 +-
 7 files changed, 72 insertions(+), 111 deletions(-)
Signature · 1 line
2.16.1.74.g9b0b1f47b