Skip to content

Cleanup waitqueue_active and barriers

David Sterba linux-btrfs 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 2 repliesIn review
  2. v23 patches 0 repliesSuperseded
  3. v12 patches 4 repliesSuperseded

Changes in v3 from the cover letter

* fix wrong use of the _nomb variant in tree-log.c:btrfs_sync_log,
* update comments to be more specific about the waitqueue_active and barrier

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3btrfs: introduce conditional wakeup helpersfs/btrfs/ctree.h+22 -00 replies
2/3btrfs: add barriers to btrfs_sync_log before log_commit_wait wakeupsfs/btrfs/tree-log.c+8 -21 reply
3/3btrfs: replace waitqueue_actvie with cond_wake_upfs/btrfs/compression.c fs/btrfs/delayed-inode.c fs/btrfs/dev-replace.c +6 more+40 -911 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchNikolay Borisov
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] Cleanup waitqueue_active and barriers

Reduce number of standalone barriers before waitqueue_active calls.

Changes v3:
* fix wrong use of the _nomb variant in tree-log.c:btrfs_sync_log,
* update comments to be more specific about the waitqueue_active and barrier

Changes v2:
* add 2 barriers to btrfs_sync_log and do not assume they're implied, (pointed out by Nikolay)

git://github.com/kdave/btrfs-devel.git cleanup/cond-wake

David Sterba (3):
btrfs: introduce conditional wakeup helpers
btrfs: add barriers to btrfs_sync_log before log_commit_wait wakeups
btrfs: replace waitqueue_actvie with cond_wake_up

 fs/btrfs/compression.c   |  7 +------
 fs/btrfs/ctree.h         | 22 ++++++++++++++++++++++
 fs/btrfs/delayed-inode.c |  9 +++------
 fs/btrfs/dev-replace.c   | 10 ++++------
 fs/btrfs/extent-tree.c   |  7 +------
 fs/btrfs/inode.c         |  9 +++------
 fs/btrfs/locking.c       | 34 +++++++++++-----------------------
 fs/btrfs/ordered-data.c  | 14 ++++----------
 fs/btrfs/transaction.c   |  7 +------
 fs/btrfs/tree-log.c      | 28 ++++++++++++----------------
 10 files changed, 62 insertions(+), 85 deletions(-)
Signature · 1 line
2.16.2